Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Qt4 support #1006

Closed
jcfr opened this issue Nov 4, 2021 · 3 comments · Fixed by #1107, #1108, #1109, #1110 or #1111
Closed

Remove Qt4 support #1006

jcfr opened this issue Nov 4, 2021 · 3 comments · Fixed by #1107, #1108, #1109, #1110 or #1111
Labels
Build System

Comments

@jcfr
Copy link
Member

jcfr commented Nov 4, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

The ctkDICOMCore and ctkDICOMWidgets have been improved to leverage features only available in Qt5 & C++11:

  • QJsonObject/QJsonDocument for the field format in ctkDICOMTableView
  • Use of foreach and std::find_if available only with C++11
  • Use of Functor-Based instead of String-Based connections

While pull request #1005 restores the possibility to build against Qt4/C++98, maintaining the Qt4 support adds an extra maintenance cost.

Describe the solution you'd like

To reduce the maintenance overhead, I propose the following plan:

  • Finalize integration of Update external projects #951
  • Create the release 2021-11-DD documenting it has been tested against Qt 4.8 / C++98 or Qt5.10 / C++11
  • Remove Qt4 support based on the following table
CTK Library Qt 4 Qt 5
CommandLineModules ✔️ ✔️
Core ✔️ ✔️
DICOM/Core ❎ ✔️
DICOM/Widgets ❎ ✔️
ImageProcessing/ITK/Core ✔️ ✔️
PluginFramework ✔️ ✔️
QtTesting ✔️ ✔️
Scripting/Python/Core ✔️ ✔️
Scripting/Python/Widgets ✔️ ✔️
Testing ✔️ ✔️
Visualization/VTK/Core ❎ ✔️
Visualization/VTK/Widgets ❎ ✔️
Widgets ✔️ ✔️
XNAT ✔️ ❓

Describe alternatives you've considered

  • Create release 2021-11-DD documenting it has been tested against Qt 4.8 / C++98 or Qt5.10 / C++11
  • Completely remove Qt4 support

Additional context

NA
@jcfr
Copy link
Member Author

jcfr commented Nov 4, 2021

cc: @lassoan @pieper @finetjul @jamesobutler

@kislinsk kislinsk mentioned this issue Nov 3, 2022
Open
1 task
@jamesobutler jamesobutler mentioned this issue Mar 3, 2023
Merged
@jcfr
Copy link
Member Author

jcfr commented Jul 18, 2023

To follow-up, CTK 2023.07.13 has been released and is the last one to support Qt 4, C++98, Python 2.7, VTK 8 and ITK v4.13.3.

Related pull requests:

This was linked to pull requests Jul 19, 2023
DOC: Update README mentioning Qt 4/C++98/Python 2.7/VTK 8/ITK v4.13.3 are unsupported #1107
Merged
COMP: Update C++ source files removing code specific to Qt 4 #1108
Merged
COMP: Require CMake >= 3.0 for project building against CTK #1109
Merged
ENH: Update CircleCI removing support for building Qt4 #1110
Merged
Remove obsolete CMake code related to CMake < 3.0 #1111
Merged
COMP: Remove support for setting CTK_QT_VERSION to "4" #1112
Merged
COMP: Update CMake files removing support for Qt 4.x #1113
Merged
DOC: Update obsolete references from doc.trolltech.com to doc.qt.io #1114
Merged
DOC: Remove obsolete references to Q_EXPORT_PLUGIN2 specific to Qt4 #1115
Merged
BUG: Re-enable support for "org.commontk.log4qt" plugin with Qt5 #1116
Merged
@jcfr
Copy link
Member Author

jcfr commented Jul 20, 2023

Following these additional pull requests, the support for building against Qt4 has been removed:

@jcfr jcfr closed this as completed Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build System
Milestone
No milestone
1 participant
@jcfr