Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cvxpy and its dependencies #1199

Closed
wants to merge 2 commits into from
Closed

added cvxpy and its dependencies #1199

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 9, 2016

test build of cvxpy and its dependencies

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cvxcanon, recipes/cvxpy, recipes/ecos, recipes/multiprocess, recipes/scs) and found some lint.

Here's what I've got...

For recipes/cvxpy:

  • The recipe could do with some maintainers listed in the "extra/recipe-maintainers" section.

For recipes/scs:

  • The recipe must have a build/number section.

# Jinja variables help maintain the recipe as you'll update the version only here.
{% set version = "0.1.1" %}
{% set sha256 = "70d7ca2e9200e2eb5d2d74131249110d8582c4227c92e553891e73c53c630fc5" %}
# sha256 is the prefered checksum -- you can get it for a file with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove all these template comments (in all recipes).

@szs8
Copy link

szs8 commented Aug 17, 2016

@enzobusseti pls update. It would be great to have this in conda-forge.

build:
- python
- setuptools
- numpy >=1.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we linking against numpy? It looks like this may be the case. If so, we need numpy x.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this may need swig too.


build:
number: 0
script: python setup.py install --single-version-externally-managed --record record.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how this is compiled? The linked repo barely has a shred of Python. 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM see the comment below on the URL.

@jakirkham
Copy link
Member

This would be some neat additions, @enzobusseti. Tried to provide you some constructive comments.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cvxcanon, recipes/cvxpy, recipes/ecos, recipes/multiprocess, recipes/scs) and found some lint.

Here's what I've got...

For recipes/cvxpy:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/scs:

  • The recipe must have a build/number section.

@jakirkham
Copy link
Member

Any thoughts on this, @enzobusseti ?

@djsutherland
Copy link
Contributor

Closing in favor of #6081 / #6076.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants