Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cvxpy, ecos, osqp, scs recipes #6076

Closed
wants to merge 5 commits into from

Conversation

djsutherland
Copy link
Contributor

Adds cvxpy and its dependencies.

Closes #3228, closes #2684, and closes #1199 which were earlier attempts at this that are now out of date. Also used somewhat as a reference http:/cvxgrp/conda-recipes/, but some things about those are out of date too.

cc @sebp, @dseuss, @enzobusseti who sent those PRs, and also @SteveDiamond; let me know if you're interested in helping maintain the recipes or you think I did anything wrong. :)

  • ecos, osqp, scs are all C libraries with multiple language interfaces, but these packages build the Python interface only for name consistency with the cvxgrp channel. The Python interfaces at least seem at a glance not to support global shared-library installs of the C libraries anyway.
  • scs would support openmp, but the system compiler on Mac doesn't. Could use gcc to force it, but does the Anaconda compiler on Mac (when we migrate to that) support it anyway?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cvxpy, recipes/ecos, recipes/osqp, recipes/scs) and found some lint.

Here's what I've got...

For recipes/osqp:

  • The "source" section was expected to be a dictionary, but got a CommentedSeq.
  • The "source" section was expected to be a dictionary, but got a CommentedSeq.

@djsutherland
Copy link
Contributor Author

(conda-smithy master says osqp is in fine form, for the record. We should maybe do a new release soon....)

@djsutherland
Copy link
Contributor Author

@conda-forge/staged-recipes Any ideas about this?

Dependency scs, version >=1.1.3 is not installable from your channels: ['local', 'conda-forge', 'defaults', 'conda-forge', 'defaults'] with subdir linux-64.  Seeing if we can build it...
rendering /home/conda/conda-recipes/scs/meta.yaml for linux-64
Traceback (most recent call last):
  File "/home/conda/.ci_support/build_all.py", line 83, in <module>
    build_all(args.recipes_dir, args.arch)
  File "/home/conda/.ci_support/build_all.py", line 57, in build_all
    config=config, finalize=False)
  File "/home/conda/.ci_support/compute_build_graph.py", line 392, in construct_graph
    recipes_dir, config=config, finalize=finalize)
  File "/home/conda/.ci_support/compute_build_graph.py", line 234, in add_recipe_to_graph
    recipes_dir=recipes_dir, finalize=finalize)
  File "/home/conda/.ci_support/compute_build_graph.py", line 464, in add_dependency_nodes_and_edges
    conda_resolve, recipes_dir, finalize=finalize)
  File "/home/conda/.ci_support/compute_build_graph.py", line 219, in add_recipe_to_graph
    rendered = _get_or_render_metadata(recipe_dir, worker, config=config, finalize=finalize)
  File "/opt/conda/lib/python3.6/site-packages/conda/exports.py", line 172, in __call__
    return self.func(*args, **kw)
  File "/home/conda/.ci_support/compute_build_graph.py", line 212, in _get_or_render_metadata
    bypass_env_check=True, config=config, finalize=finalize)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/api.py", line 51, in render
    bypass_env_check=bypass_env_check):
  File "/opt/conda/lib/python3.6/site-packages/conda_build/metadata.py", line 1926, in get_output_metadata_set
    for k in out_metadata.get_used_vars()}))] = out, out_metadata
  File "/opt/conda/lib/python3.6/site-packages/conda_build/metadata.py", line 1926, in <dictcomp>
    for k in out_metadata.get_used_vars()}))] = out, out_metadata
KeyError: 'openblas'
Exited with code 1

Seems to be caused by 86d1fec (worked before that); it's happening on Linux but not Windows or Mac. Not sure if it's a bug in .ci_support/compute_build_graph or maybe conda-build?

@isuruf
Copy link
Member

isuruf commented Jun 13, 2018

conda/conda-build#2921
#5935 (comment)

@dirmeier
Copy link
Member

dirmeier commented Jun 13, 2018

Cool! Great effort, thanks for adding this.
Mmh, looks to me as if you need to split up the PR into separate ones?

@djsutherland
Copy link
Contributor Author

@isuruf Thanks, missed that. Will split the PR....

@isuruf
Copy link
Member

isuruf commented Jun 13, 2018

This was referenced Jun 13, 2018
@djsutherland
Copy link
Contributor Author

Yeah, we should do that, but I don't know exactly what to do / am procrastinating from real work anyway so not going to figure it out right now. :)

@djsutherland djsutherland mentioned this pull request Jun 13, 2018
@djsutherland
Copy link
Contributor Author

Closing in favor of the split versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants