Add recipe for tesseract #5935

CurtLH · 2018-05-23T22:18:39Z

Closes #4647

conda-forge-linter · 2018-05-23T22:18:45Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tesseract) and found some lint.

Here's what I've got...

For recipes/tesseract:

Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter · 2018-05-23T22:20:43Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tesseract) and found some lint.

Here's what I've got...

For recipes/tesseract:

Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

CurtLH · 2018-05-23T22:29:27Z

@conda-forge/staged-recipes -- can you provide any guidance on how to handle recipes that are in bioconda but not conda-forge? Is this something where a recipe will never be merged if it's already in bioconda?

CurtLH · 2018-05-23T22:50:52Z

This recipe for tesseract was largely inspired by the existing bioconda recipe in bioconda.

This recipe for leptonica was largely inspired by the existing bioconda recipe in bioconda.

scopatz · 2018-05-23T23:31:00Z

Is this something where a recipe will never be merged if it's already in bioconda?

Actually many bioconda recipes are in conda-forge and there is no problem duplicating packages here.

scopatz · 2018-05-23T23:32:20Z

I don't know that I agree with what the linter is doing here. Perhaps @conda-forge/bioconda-recipes can shed some light.

conda-forge-linter · 2018-05-24T23:23:14Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/leptonica, recipes/tesseract) and found some lint.

Here's what I've got...

For recipes/leptonica:

Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

For recipes/tesseract:

Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

jakirkham · 2018-05-25T04:52:45Z

recipes/leptonica/meta.yaml

+ - zlib
+ - jpeg
+ - libpng
+ - libtiff


These likely all need to be in host as well. C/C++ code compiles libraries that link to libraries. So they have to be around during the build for the linking part to occur. They also need to be included at run time with matching versions (we take care of that for you under the hood). This differs from Python where they just need to be around whenever an import line calls for them. Hope that helps.

jakirkham · 2018-05-25T04:53:35Z

recipes/leptonica/meta.yaml

+ - libwebp 
+ run:
+ - zlib
+ - jpeg


Looks like this needs jpeg and openjpeg. So would add both to host and run.

Should add this based on the following lines from the log.

-- Looking for include file openjpeg-2.0/openjpeg.h -- Looking for include file openjpeg-2.0/openjpeg.h - not found -- Looking for include file openjpeg-2.1/openjpeg.h -- Looking for include file openjpeg-2.1/openjpeg.h - not found -- Looking for include file openjpeg-2.2/openjpeg.h -- Looking for include file openjpeg-2.2/openjpeg.h - not found -- Looking for include file openjpeg-2.3/openjpeg.h -- Looking for include file openjpeg-2.3/openjpeg.h - not found

ref: https://circleci.com/gh/conda-forge/staged-recipes/27445

jakirkham · 2018-05-25T04:55:15Z

recipes/leptonica/meta.yaml

+ build:
+ - {{ compiler('c') }}
+ host:
+ - cmake


This is using pkg-config as well. Currently it is reaching for the system copy, but we can provide our own (on macOS too). So please add it here.

Based on these log lines.

-- Found PkgConfig: /usr/bin/pkg-config (found version "0.23")

ref: https://circleci.com/gh/conda-forge/staged-recipes/27445

jakirkham · 2018-05-25T04:55:35Z

recipes/leptonica/meta.yaml

+ - {{ compiler('c') }}
+ host:
+ - cmake
+ - gcc # [linux]


This is handled by the compiler portion above. So it can be dropped.

jakirkham · 2018-05-25T04:55:50Z

recipes/leptonica/meta.yaml

+ host:
+ - cmake
+ - gcc # [linux]
+ - libwebp 


This should be in run as well.

jakirkham · 2018-05-25T04:56:44Z

recipes/tesseract/meta.yaml

+requirements:
+ host:
+ - gcc # [linux]
+ - llvm # [osx]


Just as you nicely did above, please add...

build: - {{ compiler('c') }}

Then drop both gcc and llvm from here.

jakirkham · 2018-05-25T04:57:19Z

recipes/tesseract/meta.yaml

+ - zlib
+ - leptonica
+ run:
+ - libgcc # [linux]


This is automatically added by the compiler syntax noted above. So we don't need to add it explicitly. IOW please go ahead and drop this.

CurtLH · 2018-06-01T19:32:15Z

Thanks for triggering the build @scopatz!

I'm not very (or at all) experienced in debugging these types of recipes, but it looks like this has something to do with why it failed:

./configure: line 17577: syntax error near unexpected token `LEPTONICA,'
./configure: line 17577: `PKG_CHECK_MODULES(LEPTONICA, lept >= 1.74, have_lept=true, have_lept=false)'

Do you have any thoughts on what to do?

scopatz · 2018-06-01T20:12:08Z

Did you push up an empty commit to trigger a rebuild? Also I think you need to wait for the leotonica package to actually appear on anaconda.org

CurtLH · 2018-06-01T20:27:34Z

Leptonica is now in Anaconda cloud, and I just pushed an empty commit, but still the same error.

mbargull · 2018-06-01T20:44:59Z

Probably just needs pkg-config as a build dependency, see tesseract-ocr/tesseract#941.

mbargull · 2018-06-01T20:45:35Z

recipes/tesseract/meta.yaml

+ - jpeg
+ - libtiff
+ - automake
+ - autoconf


automake and autoconf should go into requirements/build, if possible.

CurtLH · 2018-06-01T22:14:14Z

This one is ready for review @conda-forge/staged-recipes!

isuruf · 2018-06-01T22:18:29Z

Can you fix these warnings,

WARNING (tesseract,bin/tesseract): Needed DSO lib/libwebp.so.7 found in ['libwebp']
WARNING (tesseract,bin/tesseract): .. but ['libwebp'] not in reqs/run, i.e. it is overlinked (likely) or a missing dependency (less likely)
WARNING (tesseract,bin/tesseract): Needed DSO lib/liblzma.so.5 found in ['xz']
WARNING (tesseract,bin/tesseract): .. but ['xz'] not in reqs/run, i.e. it is overlinked (likely) or a missing dependency (less likely)
WARNING (tesseract,bin/tesseract): Needed DSO lib/libopenjp2.so.7 found in ['openjpeg']
WARNING (tesseract,bin/tesseract): .. but ['openjpeg'] not in reqs/run, i.e. it is overlinked (likely) or a missing dependency (less likely)
WARNING (tesseract,bin/tesseract): Needed DSO lib/libgif.so.7 found in ['giflib']
WARNING (tesseract,bin/tesseract): .. but ['giflib'] not in reqs/run, i.e. it is overlinked (likely) or a missing dependency (less likely)

CurtLH · 2018-06-01T22:40:06Z

Thanks for catching that @isuruf. Would this be the right way to fix this issue?

Wait to tesseract feedstock to be created
Fork tesseract feedstock
Add libwebp, xz, openjpeg, and giflib under run:requirements
Increment build number to 1
Merge fork into master

scopatz · 2018-06-01T22:41:04Z

Yes, exactly. But you should issue a PR into the feedstock from your fork.

CurtLH · 2018-06-01T22:42:26Z

That's what I meant. Will do. Thank you for your help!

scopatz · 2018-06-01T22:43:02Z

Thanks!

isuruf · 2018-06-01T22:43:44Z

Remember to do a conda smithy rerender after adding the requirements.

isuruf · 2018-06-01T22:44:07Z

You'll also want to do this for leptonica. See https://travis-ci.org/conda-forge/leptonica-feedstock/jobs/386797659#L1862-L1865

CurtLH · 2018-06-01T22:46:53Z

Will do. Thanks for spotting that!

CurtLH force-pushed the tesseract branch 16 times, most recently from 81c3017 to 34b4f1c Compare May 25, 2018 03:02

jakirkham reviewed May 25, 2018

View reviewed changes

recipes/leptonica/meta.yaml Outdated

host:

- cmake

- gcc # [linux]

- libwebp

Copy link

Member

jakirkham May 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in run as well.

jakirkham reviewed May 25, 2018

View reviewed changes

Remove leptonica

9909125

CurtLH force-pushed the tesseract branch from 60ac992 to 9909125 Compare June 1, 2018 20:18

mbargull reviewed Jun 1, 2018

View reviewed changes

CurtLH force-pushed the tesseract branch from 866182e to 29b3373 Compare June 1, 2018 21:09

Fix build dependencies

d131972

CurtLH force-pushed the tesseract branch from 29b3373 to d131972 Compare June 1, 2018 21:15

CurtLH added 2 commits June 1, 2018 17:22

Add libtool as a build dependency

3b35fd8

Try building for OSX

d3e1aa6

scopatz merged commit 35f4532 into conda-forge:master Jun 1, 2018

CurtLH deleted the tesseract branch June 1, 2018 22:16

This was referenced Jun 2, 2018

Explaining how to restart CircleCI conda-forge/conda-forge.github.io#595

Closed

log4cpp, leptonica, tesseract: remove recipes in favor of conda-forge bioconda/bioconda-recipes#9111

Merged

This was referenced Jun 2, 2018

Add missing dependencies conda-forge/leptonica-feedstock#3

Merged

Add missing dependencies conda-forge/tesseract-feedstock#1

Closed

isuruf mentioned this pull request Jun 13, 2018

add cvxpy, ecos, osqp, scs recipes #6076

Closed

djsutherland mentioned this pull request Jun 25, 2018

bug in compute_build_graph for multi-package PRs #6167

Open

ihnorton mentioned this pull request Feb 20, 2019

Add ihnorton as a maintainer and re-trigger for CircleCI conda-forge/tiledb-feedstock#26

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recipe for tesseract #5935

Add recipe for tesseract #5935

CurtLH commented May 23, 2018 •

edited

Loading

conda-forge-linter commented May 23, 2018

conda-forge-linter commented May 23, 2018

CurtLH commented May 23, 2018

CurtLH commented May 23, 2018 •

edited

Loading

scopatz commented May 23, 2018 •

edited

Loading

scopatz commented May 23, 2018

conda-forge-linter commented May 24, 2018

jakirkham May 25, 2018

jakirkham May 25, 2018 •

edited

Loading

jakirkham May 25, 2018

jakirkham May 25, 2018

jakirkham May 25, 2018

jakirkham May 25, 2018

jakirkham May 25, 2018

CurtLH commented Jun 1, 2018

scopatz commented Jun 1, 2018

CurtLH commented Jun 1, 2018

mbargull commented Jun 1, 2018

mbargull Jun 1, 2018

CurtLH commented Jun 1, 2018

isuruf commented Jun 1, 2018

CurtLH commented Jun 1, 2018

scopatz commented Jun 1, 2018

CurtLH commented Jun 1, 2018

scopatz commented Jun 1, 2018

isuruf commented Jun 1, 2018

isuruf commented Jun 1, 2018

CurtLH commented Jun 1, 2018

Add recipe for tesseract #5935

Add recipe for tesseract #5935

Conversation

CurtLH commented May 23, 2018 • edited Loading

conda-forge-linter commented May 23, 2018

conda-forge-linter commented May 23, 2018

CurtLH commented May 23, 2018

CurtLH commented May 23, 2018 • edited Loading

scopatz commented May 23, 2018 • edited Loading

scopatz commented May 23, 2018

conda-forge-linter commented May 24, 2018

jakirkham May 25, 2018

Choose a reason for hiding this comment

jakirkham May 25, 2018 • edited Loading

Choose a reason for hiding this comment

jakirkham May 25, 2018

Choose a reason for hiding this comment

jakirkham May 25, 2018

Choose a reason for hiding this comment

jakirkham May 25, 2018

Choose a reason for hiding this comment

jakirkham May 25, 2018

Choose a reason for hiding this comment

jakirkham May 25, 2018

Choose a reason for hiding this comment

CurtLH commented Jun 1, 2018

scopatz commented Jun 1, 2018

CurtLH commented Jun 1, 2018

mbargull commented Jun 1, 2018

mbargull Jun 1, 2018

Choose a reason for hiding this comment

CurtLH commented Jun 1, 2018

isuruf commented Jun 1, 2018

CurtLH commented Jun 1, 2018

scopatz commented Jun 1, 2018

CurtLH commented Jun 1, 2018

scopatz commented Jun 1, 2018

isuruf commented Jun 1, 2018

isuruf commented Jun 1, 2018

CurtLH commented Jun 1, 2018

CurtLH commented May 23, 2018 •

edited

Loading

CurtLH commented May 23, 2018 •

edited

Loading

scopatz commented May 23, 2018 •

edited

Loading

jakirkham May 25, 2018 •

edited

Loading