Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python312 #27

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python312.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https:/regro/cf-scripts/actions/runs/6893628477, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@yueyericardo
Copy link
Contributor

We replaced distutils with alternatives at aiqm/torchani#642, but it will only be available after next release.

@mikemhenry
Copy link
Contributor

We can patch it then, is 642 good? I can add it as a patch

@yueyericardo
Copy link
Contributor

Hi Mike, thanks! I believe so.

@mikemhenry
Copy link
Contributor

It built fine but crashes on import:

2023-11-16T23:22:06.9896195Z import: 'torchani'
2023-11-16T23:22:09.5044580Z Traceback (most recent call last):
2023-11-16T23:22:09.5051880Z   File "/home/conda/feedstock_root/build_artifacts/torchani_1700176070690/test_tmp/run_test.py", line 2, in <module>
2023-11-16T23:22:09.5059357Z     import torchani
2023-11-16T23:22:09.5061266Z   File "/home/conda/feedstock_root/build_artifacts/torchani_1700176070690/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.12/site-packages/torchani/__init__.py", line 39, in <module>
2023-11-16T23:22:09.5068666Z     from pkg_resources import get_distribution, DistributionNotFound
2023-11-16T23:22:09.5070860Z   File "/home/conda/feedstock_root/build_artifacts/torchani_1700176070690/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.12/site-packages/pkg_resources/__init__.py", line 2191, in <module>
2023-11-16T23:22:09.5072726Z     register_finder(pkgutil.ImpImporter, find_on_path)
2023-11-16T23:22:09.5073056Z                     ^^^^^^^^^^^^^^^^^^^
2023-11-16T23:22:09.5074029Z AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?

Looks like we need to patch out pkgutil.ImpImporter since it was removed from python 3.12 as well.

@mikemhenry
Copy link
Contributor

@yueyericardo do you want to update 642 or would you be okay with me working on the patch and then I can just update the PR with what ends up working?

@yueyericardo
Copy link
Contributor

I investigated further and found that the issue seems to be related to the version of setuptools specified in the run section. It's restricted to 65.3.0, which isn't compatible with Python 3.12.

@RaulPPelaez
Copy link
Contributor

Is there any update on this?

@h-vetinari
Copy link
Member

Needs upstream work (like aiqm/torchani#642 mentioned here already, but probably more), and we should likely also merge your #32 before

@mikemhenry
Copy link
Contributor

642 has been added as a patch, I can take a stab at patching out pkgutil.ImpImporter as well

@mikemhenry mikemhenry force-pushed the rebuild-python312-0-1_h910d9f branch from e265143 to beddc88 Compare May 15, 2024 20:11
@mikemhenry
Copy link
Contributor

hmm, from pkg_resources import get_distribution, DistributionNotFound is the bit that ends up throwing the error (from the __init__.py in torchani) BUT locally I can't reproduce that error:

>>> from pkg_resources import get_distribution, DistributionNotFound
<stdin>:1: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

pkg_resources is deprecated anyway so I can still patch it out

@mikemhenry
Copy link
Contributor

Looks like we will need to patch pkbar as well

@mikemhenry
Copy link
Contributor

damn it looks like it works but I got this error on the CI "RuntimeError: Shared memory manager connection has timed out" https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=935666&view=logs&j=385a3385-ae8b-54d1-9abe-3c614f74cb73

Going to restart CI and see if that makes it work

@mikemhenry
Copy link
Contributor

Sweet! It all looks good, will work on pytorch next

@mikemhenry mikemhenry merged commit c1ffb8d into conda-forge:main May 16, 2024
22 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python312-0-1_h910d9f branch May 16, 2024 17:42
@mikemhenry
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants