-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for python312 #27
Rebuild for python312 #27
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
We replaced |
We can patch it then, is 642 good? I can add it as a patch |
Hi Mike, thanks! I believe so. |
It built fine but crashes on import:
Looks like we need to patch out |
@yueyericardo do you want to update 642 or would you be okay with me working on the patch and then I can just update the PR with what ends up working? |
I investigated further and found that the issue seems to be related to the version of setuptools specified in the run section. It's restricted to 65.3.0, which isn't compatible with Python 3.12. |
Is there any update on this? |
Needs upstream work (like aiqm/torchani#642 mentioned here already, but probably more), and we should likely also merge your #32 before |
642 has been added as a patch, I can take a stab at patching out |
e265143
to
beddc88
Compare
…nda-forge-pinning 2024.05.15.19.07.12
hmm,
|
Looks like we will need to patch |
damn it looks like it works but I got this error on the CI "RuntimeError: Shared memory manager connection has timed out" https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=935666&view=logs&j=385a3385-ae8b-54d1-9abe-3c614f74cb73 Going to restart CI and see if that makes it work |
Sweet! It all looks good, will work on pytorch next |
tracking merge to main here https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=935805&view=results |
This PR has been triggered in an effort to update python312.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https:/regro/cf-scripts/actions/runs/6893628477, please use this URL for debugging.