Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax CUDA run requirements #32

Merged
merged 17 commits into from
May 15, 2024
Merged

Conversation

RaulPPelaez
Copy link
Contributor

@RaulPPelaez RaulPPelaez commented Feb 15, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This PR allows to install torchani with latest CUDA versions (12.3). Before, being cuda-version pinned in run reqs, a build for CUDA 12.0 would only be installable with that specific version.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@RaulPPelaez
Copy link
Contributor Author

@conda-forge-admin, please rerender

@RaulPPelaez
Copy link
Contributor Author

Running out of space. I will assume it is a temporary issue...

@RaulPPelaez
Copy link
Contributor Author

Python 3.8 fails because cuaev does not find crypt.h (wonder how it ever worked).

@RaulPPelaez
Copy link
Contributor Author

The python 3.8 failures are related to this conda-forge/linux-sysroot-feedstock#52

@RaulPPelaez
Copy link
Contributor Author

Finally! @mikemhenry please review!

recipe/meta.yaml Outdated Show resolved Hide resolved
@RaulPPelaez
Copy link
Contributor Author

Ok done! @mikemhenry ready or review again

@h-vetinari h-vetinari mentioned this pull request May 14, 2024
@mikemhenry
Copy link
Contributor

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mikemhenry
Copy link
Contributor

Sorry this took so long! @hadim or @yueyericardo does this look good?

Copy link
Contributor

@yueyericardo yueyericardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long, LGTM!

@mikemhenry mikemhenry merged commit 4783526 into conda-forge:main May 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants