remove the 'version' section from the health checks (#305)

- remove the 'version' section from the health checks

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https:/dart-lang/.github/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Most changes should add an entry to the changelog and may need to [rev
the pubspec package
version](https:/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding
tests](https:/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs -
please allow for some latency before initial review feedback.
</details>

.github/workflows/health.yaml

@@ -21,8 +21,8 @@ name: Health
 # uses: dart-lang/ecosystem/.github/workflows/health.yaml@main
 # with:
 # sdk: beta
-# checks: "version,changelog,license,coverage,breaking,do-not-submit,leaking"
-# fail_on: "version,changelog,do-not-submit"
+# checks: "changelog,license,coverage,breaking,do-not-submit,leaking"
+# fail_on: "changelog,do-not-submit"
 # warn_on: "license,coverage,breaking,leaking"
 # coverage_web: false
 # upload_coverage: false
@@ -52,17 +52,17 @@ on:
  # Restrict the checks to any subset of version, changelog, and license if
  # needed.
  checks:
- description: What to check for in the PR health check - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
- default: "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+ description: What to check for in the PR health check - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
+ default: "changelog,license,coverage,breaking,do-not-submit,leaking"
  type: string
  required: false
  fail_on:
- description: Which checks should lead to failure - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
- default: "version,changelog,do-not-submit"
+ description: Which checks should lead to failure - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
+ default: "changelog,do-not-submit"
  type: string
  required: false
  warn_on:
- description: Which checks should not fail, but only warn - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+ description: Which checks should not fail, but only warn - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
  default: "license,coverage,breaking,leaking"
  type: string
  required: false
@@ -113,19 +113,6 @@ on:
  required: false
 
 jobs:
- version:
- if: ${{ contains(inputs.checks, 'version') }}
- uses: ./.github/workflows/health_base.yaml
- with:
- sdk: ${{ inputs.sdk }}
- check: version
- fail_on: ${{ inputs.fail_on }}
- warn_on: ${{ inputs.warn_on }}
- local_debug: ${{ inputs.local_debug }}
- use-flutter: ${{ inputs.use-flutter }}
- ignore_packages: ${{ inputs.ignore_packages }}
- checkout_submodules: ${{ inputs.checkout_submodules }}
-
  changelog:
  if: ${{ contains(inputs.checks, 'changelog') }}
  uses: ./.github/workflows/health_base.yaml
@@ -210,7 +197,7 @@ jobs:
  checkout_submodules: ${{ inputs.checkout_submodules }}
 
  comment:
- needs: [version, changelog, license, coverage, breaking, do-not-submit, leaking]
+ needs: [changelog, license, coverage, breaking, do-not-submit, leaking]
  if: always()
  # These permissions are required for us to create comments on PRs.
  permissions:

.github/workflows/health_base.yaml

@@ -16,16 +16,16 @@ on:
  required: false
  type: string
  check:
- description: What to check for in the PR health check - any of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+ description: What to check for in the PR health check - any of "changelog,license,coverage,breaking,do-not-submit,leaking"
  type: string
  required: true
  fail_on:
- description: Which checks should lead to failure - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
- default: "version,changelog,do-not-submit"
+ description: Which checks should lead to failure - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
+ default: "changelog,do-not-submit"
  type: string
  required: false
  warn_on:
- description: Which checks should not fail, but only warn - any subset of "version,changelog,license,coverage,breaking,do-not-submit,leaking"
+ description: Which checks should not fail, but only warn - any subset of "changelog,license,coverage,breaking,do-not-submit,leaking"
  default: "license,coverage,breaking,leaking"
  type: string
  required: false

.github/workflows/health_internal.yaml

@@ -12,8 +12,8 @@ jobs:
  local_debug: true
  coverage_web: false
  upload_coverage: false
- checks: version,changelog,license,coverage,breaking,do-not-submit,leaking
- fail_on: version,changelog,do-not-submit
+ checks: changelog,license,coverage,breaking,do-not-submit,leaking
+ fail_on: changelog,do-not-submit
  warn_on: license,coverage,breaking,leaking
  ignore_license: 'pkgs/firehose/test_data'
  ignore_coverage: 'pkgs/firehose/bin,pkgs/firehose/test_data'

pkgs/firehose/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.10.0
+
+- Remove the `version` pubspec checks (these largely duplicate the feedback
+ provided by publishing automation).
+
 ## 0.9.3
 
 - Do not check Dart SDK in PR Health breaking check.