Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the 'version' section from the health checks #305

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

devoncarew
Copy link
Member

  • remove the 'version' section from the health checks

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.10.0 ready to publish firehose-v0.10.0
package:dart_flutter_team_lints 3.2.1 already published at pub.dev

Documentation at https:/dart-lang/ecosystem/wiki/Publishing-automation.

@devoncarew
Copy link
Member Author

Unhandled exception:
FormatException: "version" is not an allowed value for option "fail_on".
#0      Parser._validate (package:args/src/parser.dart:311:[21](https:/dart-lang/ecosystem/actions/runs/11242751471/job/31257125949?pr=305#step:11:22))
#1      Parser._validateAllowed (package:args/src/parser.dart:349:5)
#2      Parser._setOption (package:args/src/parser.dart:329:9)
#3      Parser._readNextArgAsValue (package:args/src/parser.dart:125:5)
#4      Parser._handleLongOption (package:args/src/parser.dart:281:9)
#5      Parser._parseLongOption (package:args/src/parser.dart:[26](https:/dart-lang/ecosystem/actions/runs/11242751471/job/31257125949?pr=305#step:11:27)4:12)
#6      Parser.parse (package:args/src/parser.dart:86:11)
#7      ArgParser.parse (package:args/src/arg_parser.dart:334:42)
#8      main (file:///home/runner/work/ecosystem/ecosystem/current_repo/pkgs/firehose/bin/health.dart:52:32)

Copy link

github-actions bot commented Oct 8, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose Non-Breaking 0.9.3 0.10.0 0.9.4 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage
pkgs/firehose/lib/src/health/health.dart 💚 95 %
pkgs/firehose/lib/src/utils.dart 💚 24 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@devoncarew
Copy link
Member Author

@mosuem - thoughts on this in general? I think the publishing validation info from the health workflow is largely duplicative of the comment from the publishing automation workflow.

Copy link
Member

@mosuem mosuem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG!

@devoncarew devoncarew marked this pull request as ready for review October 11, 2024 18:30
@devoncarew devoncarew merged commit d5c8c18 into main Oct 15, 2024
28 checks passed
@devoncarew devoncarew deleted the remove_version_check branch October 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants