Migrate test and use adapter zone base classes. #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McKnight-42
approved these changes
Jan 28, 2023
colin-rogers-dbt
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add on for the persist docs to adapter zone conversion.
Description
This code needed some cleanup. Able to do that with the adapter zone version of these tests.
I didn't include the quoted column test because it's unclear to me how to make it work. Following the bigquery docs, I used backticks to escape the 2id column, but dbt run still fails. Is it right to elide this test case as unsupported or is there something I should try besides quoting the column identifier?
Checklist