Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ct 1827/064 column comments tests conversion #6766

Merged
merged 10 commits into from
Jan 31, 2023

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Jan 27, 2023

resolves #6623
Followup to #6654

Description

Ports persist column tests to the adapter zone.

I'm proceeding to duplicate this test across adapter repos. However, there is no reason to delay reviewing and merging this one. Those tests Ill write elsewhere will point to this code one way or another.

Although not a blocker, here's some bookkeeping on supplementary persist docs conversions in adapter repos:

  • dbt-redshift
  • dbt-snowflake
  • dbt spark (in flight)
  • dbt bigquery (blocked on setup issues to be resolved Friday)

Checklist

@VersusFacit VersusFacit requested a review from a team as a code owner January 27, 2023 08:12
@VersusFacit VersusFacit self-assigned this Jan 27, 2023
@VersusFacit VersusFacit requested a review from a team as a code owner January 27, 2023 08:12
@cla-bot cla-bot bot added the cla:yes label Jan 27, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Jan 27, 2023
@VersusFacit VersusFacit merged commit 42b7caa into main Jan 31, 2023
@VersusFacit VersusFacit deleted the CT-1827/064_column_comments_tests_conversion branch January 31, 2023 20:58
@iknox-fa iknox-fa restored the CT-1827/064_column_comments_tests_conversion branch January 31, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1827] 064_column_comments_tests
3 participants