Skip to content

Commit

Permalink
scrub message of secrets (#4507)
Browse files Browse the repository at this point in the history
* scrub message of secrets

* update changelog

* use new scrubbing and scrub more places using git

* fixed small miss of string conv and missing raise

* fix bug with cloning error

* resolving message issues

* better, more specific scrubbing

automatic commit by git-black, original commits:
  7c46b78
  • Loading branch information
emmyoop authored and iknox-fa committed Feb 8, 2022
1 parent 922819a commit 1390e27
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
7 changes: 5 additions & 2 deletions core/dbt/clients/git.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@
GitProgressCheckedOutAt,
)
from dbt.exceptions import (
CommandResultError, RuntimeException, bad_package_spec, raise_git_cloning_error,
raise_git_cloning_problem
CommandResultError,
RuntimeException,
bad_package_spec,
raise_git_cloning_error,
raise_git_cloning_problem,
)
from packaging import version

Expand Down
4 changes: 2 additions & 2 deletions core/dbt/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -470,10 +470,10 @@ def raise_git_cloning_error(error: CommandResultError) -> NoReturn:

def raise_git_cloning_problem(repo) -> NoReturn:
repo = scrub_secrets(repo, env_secrets())
msg = '''\
msg = """\
Something went wrong while cloning {}
Check the debug logs for more information
'''
"""
raise RuntimeException(msg.format(repo))


Expand Down

0 comments on commit 1390e27

Please sign in to comment.