scrub message of secrets #4507
Merged
scrub message of secrets #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not checked that this works locally yet but wanted to get up the PR. |
|
To be safe, let's also add scrubbing logic to all potential exceptions raised in the
There's two other worrying spots where we |
leahwicz
approved these changes
Dec 17, 2021
|
Converting this one into a |
emmyoop
added a commit
that referenced
this pull request
Dec 17, 2021
* scrub message of secrets * update changelog * use new scrubbing and scrub more places using git * fixed small miss of string conv and missing raise * fix bug with cloning error * resolving message issues * better, more specific scrubbing
Merged
leahwicz
pushed a commit
that referenced
this pull request
Dec 19, 2021
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* scrub message of secrets * update changelog * use new scrubbing and scrub more places using git * fixed small miss of string conv and missing raise * fix bug with cloning error * resolving message issues * better, more specific scrubbing automatic commit by git-black, original commits: 7c46b78
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* scrub message of secrets * update changelog * use new scrubbing and scrub more places using git * fixed small miss of string conv and missing raise * fix bug with cloning error * resolving message issues * better, more specific scrubbing automatic commit by git-black, original commits: 7c46b78 9cc7a7a
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4508
Description
Scrub
bad_package_spec()of secrets it may contain in output.Checklist
CHANGELOG.mdand added information about my change