[Bug] Threading model prevents exceptions in threads from reaching logging in a meaningful way

[iknox-fa]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

During the course of resolving #4424 it was discovered that exceptions caused within threads during runtime don't surface to the user in a meaningful way. My current understanding is that is due to the threading model we currently use, although this needs further verification.

Expected Behavior

Exceptions are visible to the user

Steps To Reproduce

Revert changes made in #4424
Run the test suite with json output enabled

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

What database are you using dbt with?

No response

Additional Context

No response

[jtcohen6]

@iknox-fa Is this the same as the issue described in #4357? Let's close one and keep one open, whichever has the most useful + up-to-date info.

My sense is that this is only relevant for internal-to-dbt exceptions (e.g. failure to serialize logs to JSON). Any database errors that threaded execution encounters, even unhandled ones, are bubbled up appropriately.

[iknox-fa]

@jtcohen6 Yep same thing, sorry I missed it in the search step. Closing this one.