Stringify generic exceptions #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
approved these changes
Dec 3, 2021
nathaniel-may
approved these changes
Dec 3, 2021
leahwicz
pushed a commit
that referenced
this pull request
Dec 3, 2021
4 tasks
leahwicz
added a commit
that referenced
this pull request
Dec 3, 2021
Co-authored-by: Ian Knox <[email protected]>
iknox-fa
added a commit
that referenced
this pull request
Feb 8, 2022
automatic commit by git-black, original commits: 22b1a09
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: No ticket
Description
Changes the default behavior for logging generic exceptions at runtime which was causing hangs when logging to any JSON output.
They will now be handled as strings until we refine our exception serialization process.
Checklist
CHANGELOG.mdand added information about my change