Structlog #4176
Closed
Structlog #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add event type modeling and fire_event calls
* updated context dir to new structured logging
handle exec info
update log call sites with new event system
graph call sites for structured logging
nathaniel-may
changed the base branch from
main
to
feature/structured-logging
nathaniel-may
commented
Nov 1, 2021
nathaniel-may
commented
Nov 1, 2021
nathaniel-may
commented
Nov 1, 2021
added 2 commits
November 2, 2021 10:46
4 tasks
4 tasks
This was referenced Nov 5, 2021
5 tasks
emmyoop
force-pushed
the
feature/structured-logging
branch
from
89e478f
to
66cece0
Compare
nathaniel-may
force-pushed
the
feature/structured-logging
branch
from
3684a5f
to
31acb95
Compare
|
closing in favor of #4231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds structlog to the event module as the new logging library. The existing logger will be removed once all the call sites have been modified to use the event module.
Before:
After:
Notable differences:
This PR also includes the new logging interface for adapters from #4161. The tests had an issue with Logbook, so I moved the changes here where there is no Logbook to save time.
Todo:
Checklist
CHANGELOG.mdand added information about my change