missed call site contracts #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
approved these changes
Nov 5, 2021
|
interesting. flake8 should be catching these 🤔 |
|
The #noqa keeps it from being caught. I've searched the entire project and I think with your changes coming in #4176 they'll all be taken care of. |
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
emmyoop
added a commit
that referenced
this pull request
Nov 8, 2021
kwigley
pushed a commit
that referenced
this pull request
Nov 9, 2021
nathaniel-may
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missed an unused import in
core/dbt/contracts/project.pyChecklist
CHANGELOG.mdand added information about my change