Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate persist docs to an adapter zone variant. #416

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

VersusFacit
Copy link
Contributor

Add on for the persist docs to adapter zone conversion.

Description

This code needed some cleanup. Able to do that with the adapter zone version of these tests.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Jan 27, 2023
@VersusFacit VersusFacit self-assigned this Jan 27, 2023
@cla-bot cla-bot bot added the cla:yes label Jan 27, 2023
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https:/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https:/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https:/dbt-labs/dbt-core.git@69846369c5d5d69eb50b565bcc684159bd7eefa4#egg=dbt-core&subdirectory=core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be reverted when the base version is merged

@VersusFacit VersusFacit merged commit 471d07e into main Jan 31, 2023
@VersusFacit VersusFacit deleted the CT-1827/064_column_comments_tests_conversion branch January 31, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants