Fix setup_db.sh by waiting for pg_isready success return. Fixes #3876 #3908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3876
Description
The
setup_db.sh
script now waits for the postgres instance to be ready before terminating execution. Code for the creation ofdbt
database,root
roles and grants ondbt
has been removed since this is already done in the docker compose. The creation of rolenoaccess
and dbdbtMixedCase
is kept.Mind that I didn't successfully run
make integration
because I get an import error on all the tests ondbt.main
. What I tested is that after the script ends I'm able to connect to postgres with:psql postgresql://root:password@localhost:5432/dbtMixedCase
psql postgresql://root:password@localhost:5432/dbt
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.