-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operationMetrics to WRITE #1992
Comments
I'm interested in contributing to the project and can take a look at this one. Thanks! |
After reviewing the metrics implementations for Merge and Delete it should be easy enough to replicate the same things in write. However, in write.rs the Output type for IntoFuture is a DeltaTable impl std::future::IntoFuture for WriteBuilder {
type Output = DeltaResult<DeltaTable>; and to conform to the other operations and surface the metrics it would change to: impl std::future::IntoFuture for WriteBuilder {
type Output = DeltaResult<(DeltaTable, WriteMetrics)>; I just wanted to surface that since this "good first issue" may touch a fair amount of files 😄 |
@gavinmead you can do the first iteration where we just record the metrics in the commit but don't return them together with the DeltaTable instance |
Description
Currently
WriteBuilder
does not collect the metrics as other operations do (e.g.delete
ormerge
)Use Case
Related Issue(s)
The text was updated successfully, but these errors were encountered: