Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operationMetrics to WRITE #1992

Closed
r3stl355 opened this issue Dec 26, 2023 · 3 comments · Fixed by #2838
Closed

Add operationMetrics to WRITE #1992

r3stl355 opened this issue Dec 26, 2023 · 3 comments · Fixed by #2838
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@r3stl355
Copy link
Contributor

Description

Currently WriteBuilder does not collect the metrics as other operations do (e.g. delete or merge)

Use Case

Related Issue(s)

@r3stl355 r3stl355 added the enhancement New feature or request label Dec 26, 2023
@ion-elgreco ion-elgreco added the good first issue Good for newcomers label Aug 19, 2024
@gavinmead
Copy link
Contributor

I'm interested in contributing to the project and can take a look at this one. Thanks!

@gavinmead
Copy link
Contributor

After reviewing the metrics implementations for Merge and Delete it should be easy enough to replicate the same things in write. However, in write.rs the Output type for IntoFuture is a DeltaTable

impl std::future::IntoFuture for WriteBuilder {
    type Output = DeltaResult<DeltaTable>;

and to conform to the other operations and surface the metrics it would change to:

impl std::future::IntoFuture for WriteBuilder {
    type Output = DeltaResult<(DeltaTable, WriteMetrics)>;

I just wanted to surface that since this "good first issue" may touch a fair amount of files 😄

@ion-elgreco
Copy link
Collaborator

@gavinmead you can do the first iteration where we just record the metrics in the commit but don't return them together with the DeltaTable instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants