Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add operationMetrics to WRITE #2838

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

gavinmead
Copy link
Contributor

Description

The PR contains the following:

  • Defines a WriteMetrics struct
  • Writes metrics to app_metadata under key "operationMetrics"
  • Adds assertions to unit tests that get the latest commit info and check that metrics have been written
  • Updates a few test assertions that changed because the commit info has more metadata.

Related Issue(s)

closes #1992

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 80.68966% with 28 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (c4f4ee0) to head (526c0f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/write.rs 80.68% 0 Missing and 28 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2838      +/-   ##
==========================================
+ Coverage   72.49%   72.50%   +0.01%     
==========================================
  Files         132      132              
  Lines       39892    40029     +137     
  Branches    39892    40029     +137     
==========================================
+ Hits        28918    29023     +105     
+ Misses       9151     9141      -10     
- Partials     1823     1865      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rtyler
rtyler previously approved these changes Sep 3, 2024
this commit includes the following changes:
* Defines a WriteMetrics struct
* Writes metrics to app_metadata under key "operationMetrics"
* Adds assertions to unit tests that get the latest commit info and check that metrics have been written
* Updates a few test assertions that changed because the commit info has more metadata.
@rtyler rtyler added this pull request to the merge queue Sep 3, 2024
Merged via the queue into delta-io:main with commit de11e6b Sep 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add operationMetrics to WRITE
2 participants