fix: just make pyarrow 12 the max #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust 1.72 was particularly annoyed by these missing docs 🤷
I don't understand how this wasn't failing before since filesystem is Optional
in the type, error in Actions:
mypy
deltalake/writer.py:223: error: Item "None" of "Optional[Any]" has no attribute "get_file_info" [union-attr]
Found 1 error in 1 file (checked 7 source files)
wjones127
requested review from
fvaleye,
rtyler,
roeap and
houqp
as code owners
|
@rtyler I merged your PR into here with some more Python fixes. CI should all be green :) |
rtyler
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a temporary fix until I have more time to finish #1602.
Related Issue(s)
Documentation