Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: just make pyarrow 12 the max #1603

Merged
merged 9 commits into from
Aug 28, 2023
Merged

fix: just make pyarrow 12 the max #1603

merged 9 commits into from
Aug 28, 2023

Commits on Aug 25, 2023

  1. Beginning to fix clippy errors on the latest Rust 1.72

    @rtyler
    rtyler committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5aef21a View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Add missing doc strings to the LocalFileSystemError 

    Rust 1.72 was particularly annoyed by these missing docs 🤷
    @rtyler
    rtyler committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    0b966dd View commit details
    Browse the repository at this point in the history

  2. Removing some now unnecessary according to clippy code

    @rtyler
    rtyler committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    d1cc3cf View commit details
    Browse the repository at this point in the history

  3. Remove into_iter() clippy warning too

    @rtyler
    rtyler committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    3acacf4 View commit details
    Browse the repository at this point in the history

  4. Handle the possibility that a filesystem is None when writing in Python 

    I don't understand how this wasn't failing before since filesystem is Optional
in the type, error in Actions:

    mypy
    deltalake/writer.py:223: error: Item "None" of "Optional[Any]" has no attribute "get_file_info"  [union-attr]
    Found 1 error in 1 file (checked 7 source files)
    @rtyler
    rtyler committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    a2a279c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. temporary fix: just max 12 the max

    @wjones127
    wjones127 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0246f06 View commit details
    Browse the repository at this point in the history

  2. ci fixes

    @wjones127
    wjones127 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    cefe533 View commit details
    Browse the repository at this point in the history

  3. add dumb fix

    @wjones127
    wjones127 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2afdf1c View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'rtyler/new-rust-who-dis' into fix/pyarr… 

    …ow-fix-12
    @wjones127
    wjones127 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6e3a443 View commit details
    Browse the repository at this point in the history