fix: trim trailing slash in url storage options (#2656) #2775
Conversation
omkar-foss
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
|
Tried closing PR #2770 and re-opening the same here in this PR, but the workflows are still stuck at |
Workflows require approval each time |
Ohhh got it, thanks! 👍🏽 |
| .map(|(k, v)| { | ||
| let needs_trim = v.starts_with("http://") | ||
| || v.starts_with("https://") | ||
| || k.to_lowercase().ends_with("_url"); |
There was a problem hiding this comment.
what are we checking here? i.e. what does a _url suffix signify?
I'm probably just missing something obvious 😆.
There was a problem hiding this comment.
ah - from the tests i gather this is a convention we are introducing?
Should we document this behavior in a docstring somewhere?
This trims trailing slash if present in a storage option's value if it's key ends with `_URL` (e.g. `HOST_URL`) or if the value itself seems to be a url (i.e. starts with `http://` or `https://`). This also adds supporting test for this fix.
omkar-foss
force-pushed
the
trim-slash-storage-opts
branch
from
fb50878
to
b30d5c3
Compare
Description
This trims trailing slash if present in a storage option's value
if it's key ends with
_URL(e.g.HOST_URL) or if the valueitself seems to be a url (i.e. starts with
http://orhttps://).This also adds supporting test for this fix.
Related Issue(s)
Documentation
N/A