Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trim trailing slash in url storage options (#2656) #2775

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix: trim trailing slash in url storage options (#2656) #2775

merged 2 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. fix: trim trailing slash in url storage options (delta-io#2656) 

    This trims trailing slash if present in a storage option's value
if it's key ends with `_URL` (e.g. `HOST_URL`) or if the value
itself seems to be a url (i.e. starts with `http://` or `https://`).

This also adds supporting test for this fix.
    @omkar-foss
    omkar-foss committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    77a442d View commit details
    Browse the repository at this point in the history

  2. Add docstring for option trailing slash trimming

    @omkar-foss
    omkar-foss committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b30d5c3 View commit details
    Browse the repository at this point in the history