Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Implement DOMException's stack property. #12294

Merged
merged 3 commits into from
Oct 3, 2021

Conversation

andreubotella
Copy link
Contributor

As per WebIDL, if Error objects have a stack property, so should DOMException instances.

Andreu Botella added 3 commits October 1, 2021 22:23
As per WebIDL (https://heycam.github.io/webidl/#es-DOMException-specialness),
if `Error` objects have a `stack` property, so should `DOMException`
instances.
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 2170a41 into denoland:main Oct 3, 2021
@andreubotella andreubotella deleted the dom-exception-stack branch October 3, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants