Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): Format DOMException's stack property #12333

Merged
merged 1 commit into from
Oct 8, 2021
Merged

fix(web): Format DOMException's stack property #12333

merged 1 commit into from
Oct 8, 2021

Conversation

petamoriken
Copy link
Contributor

Related: #12294

I removed the "Error: " string from the DOMException's stack property.

before:

after:

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@bartlomieju
Copy link
Member

CC @andreubotella

andreubotella
andreubotella approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@andreubotella andreubotella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartlomieju
bartlomieju approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartlomieju bartlomieju merged commit 5f405bf into denoland:main Oct 8, 2021
@petamoriken petamoriken deleted the fix/domexception-stack branch October 8, 2021 22:10
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Oct 10, 2021
@petamoriken @bartlomieju
fix(ext/web): Format DOMException stack property (denoland#12333)
308f029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreubotella andreubotella andreubotella approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petamoriken @CLAassistant @bartlomieju @andreubotella