feat: Support custom host objects in ValueSerializer #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Note. While I am fairly confident the changes in this PR are correct, I am still working through the corresponding changes in deno_core required to make use of this functionality. |
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 16, 2023
This avoids substantial slowdowns caused by host objects using embedded fields. Depends on: denoland/rusty_v8#1322 Current status: For some reason v8::Symbol::for_global is returning a different symbol to the one defined in 01_core.js. running 2 tests from ./cli/tests/unit/message_channel_test.ts messagechannel ... ok (34ms) messagechannel clone port ...result=Some(false) constructor=Object keys.length=0, identity hash:499026937 result=Some(false) constructor=MessagePort keys.length=4, identity hash:499026937 0 symbol "Deno.core.customHostObject" is false, hash 253732785 1 symbol "[[webidl.brand]]" is false, hash 764160415 2 symbol "undefined" is false, hash 758685447 3 symbol "id" is false, hash 997007839
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 16, 2023
This avoids substantial slowdowns caused by host objects using embedded fields. Depends on: denoland/rusty_v8#1322 Current status: For some reason v8::Symbol::for_global is returning a different symbol to the one defined in 01_core.js. ``` $ ./target/debug/deno test cli/tests/unit/message_channel_test.ts running 2 tests from ./cli/tests/unit/message_channel_test.ts messagechannel ... ok (35ms) messagechannel clone port ...result=Some(false) constructor=Object keys.length=0, identity hash:560437950 is_object false is_symbol true result=Some(false) constructor=MessagePort keys.length=4, identity hash:560437950 is_object false is_symbol true 0 symbol "Deno.core.customHostObject" is false, hash 253732785 is_object false is_symbol true 1 symbol "[[webidl.brand]]" is false, hash 764160415 is_object false is_symbol true 2 symbol "undefined" is false, hash 758685447 is_object false is_symbol true 3 symbol "id" is false, hash 997007839 is_object false is_symbol true Uncaught error from ./cli/tests/unit/message_channel_test.ts FAILED messagechannel clone port ... cancelled (0ms) ```
lrowe
force-pushed
the
lrowe-custom-host-object
branch
from
ceb44f7
to
2519008
Compare
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 17, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 17, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
force-pushed
the
lrowe-custom-host-object
branch
from
2519008
to
a1bb32a
Compare
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 17, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
force-pushed
the
lrowe-custom-host-object
branch
3 times, most recently
from
86c185a
to
f3f55bf
Compare
lrowe
force-pushed
the
lrowe-custom-host-object
branch
from
f3f55bf
to
2545a61
Compare
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 27, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 27, 2023
legendecas
reviewed
Oct 27, 2023
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 7, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
|
With the change to has_custom_host_object I think this is ready for merging. @legendecas could you approve your review unless you have other concerns? |
mmastrac
approved these changes
Nov 18, 2023
|
Yup, I'll review tonight. |
bartlomieju
approved these changes
Nov 20, 2023
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 27, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add v8::ValueSerializerImpl::{has_custom_host_object,is_host_object} equivalents for v8::ValueSerializer::Delegate::{HasCustomHostObject,IsCustomHostObject}.
This enables serializing custom host objects without embedder fields.