fix(Symbol): deprecate for_global in favour of for_key and for_api
#1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 17, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 17, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
`for_global` was documented as `for_key` but implemented as `for_api`. Closes denoland#1323
auto-merge was automatically disabled
September 17, 2023 18:04
Head branch was pushed to by a user without write access
lrowe
force-pushed
the
lrowe-fix-symbol-for-global
branch
from
0e80bf8
to
a198203
Compare
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 17, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Sep 27, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 7, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 27, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
lrowe
added a commit
to lrowe/deno_core
that referenced
this pull request
Nov 28, 2023
Avoids substantial slowdown caused by host objects with embedder fields. * Depends on: denoland/rusty_v8#1322 * Depends on: denoland/rusty_v8#1324 * Deno bug: denoland/deno#12067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for_globalwas documented asfor_keybut implemented asfor_api.Closes #1323