-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in .net 4.7.1 #500
Comments
@StasPerekrestov - thanks for linking that issue and letting us know! Regarding Moq's use of Let's leave this issue open so we can gather some benchmark data on just how badly Moq's performance is affected—by its use of |
@stakx I don't have access to machine without latest Windows 10 Creators update, so I can't really give you comparison times, but this issue hit me really hard. For example I have some tests that setup things on |
@Caleb9: Your vote has been heard. :) I would say it is very likely that Microsoft will fix this. However, I realise that until this happens, the situations is... problematic. Moq currently collects source file information for each setup by default. I think this needs to become an opt-in feature: it's there if people want this diagnostic information; and it won't incur any performance cost for people who don't need it. Given that version 4.8.0 of Moq isn't quite ready yet I'm wondering whether a hotfix release is required...? |
@Caleb9, @StasPerekrestov - I have just published a hotfix release of Moq (version 4.7.145). Source file information collection via If you want the old behavior back, i.e. you want better diagnostic messages when doing a You shouldn't have any more trouble regarding this issue after you upgrade to 4.7.145 or later. If you do, please post back here! |
Hello,
just FYI. There is a potential regression in .net 4.7.1 that significantly affects moq Setup API logic.
The text was updated successfully, but these errors were encountered: