-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check why there's both MethodCall.ToString
and MethodCall.Format
, and whether we can drop one of them (ideally including MethodCall.SetFileInfo
)
#503
Comments
|
According to #500, .NET 4.7.1 has a regression that makes calls to
new StackTrace()
super costly. Moq only instantiates theStackTrace
class for debugging purposes only, for the use in one of two formatting methods ofMethodCall
.Why does
MethodCall
have two different formatting methods? Wouldn't a single one suffice? Ideally, we'd discover that the one usingStackTrace
information is the less frequently used one and can be replaced with the more commonly used one. ThenStackTrace
instantiation would become redundant and the .NET 4.7.1 performance issue evaporates.The text was updated successfully, but these errors were encountered: