driver: remove unnecessary waitActionTimeout #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
approved these changes
May 12, 2022
driver/controller.go
Outdated
| err := wait.PollUntil(1*time.Second, wait.ConditionFunc(func() (done bool, err error) { | ||
| action, _, err := d.storageActions.Get(ctx, volumeID, actionID) | ||
| action, resp, err := d.storageActions.Get(ctx, volumeID, actionID) |
There was a problem hiding this comment.
resp is still unused, which might trigger certain Go linters to emit a warning.
waynr
force-pushed
the
wwarren/handle-get-actions-404-responses
branch
from
10cca17
to
5f15606
Compare
|
I created a new branch. The new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in discussion of https://jira.internal.digitalocean.com/browse/CON-6582 where we determined that this timeout is unnecessary due to the timeout that gets set on the gRPC method call context.