driver: remove unnecessary waitActionTimeout (v2.x) #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Docker seem to fail when using the default platform since Darwin on amd64 has become a dedicated image architecture with Docker: e2e_test.go:284: end-to-end tests failed: failed to create container: Error response from daemon: image with reference docker.io/digitalocean/k8s-e2e-test-runner:latest was found but does not match the specified platform: wanted darwin/amd64, actual: linux/amd64 Not setting the platform ensures the Linux image is requested.
Signed-off-by: Carlos Panato <[email protected]>
waynr
force-pushed
the
wwarren/2.x/handle-get-actions-404-responses
branch
from
ba0b654
to
0e42076
Compare
|
Note -- I also pulled in some CI and other harmless-looking changes from master branch. |
timoreimann
changed the title
|
We may end up not needing this after all; let's keep it open for now. |
|
The improvements will only go into v3+ of the driver. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.