-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(watch): Add debug log when skipping service without build context #12067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Suleiman Dibirov <[email protected]>
7a42d18
to
1ff398f
Compare
pkg/compose/watch.go
Outdated
@@ -37,8 +37,8 @@ import ( | |||
"github.com/docker/docker/api/types/container" | |||
"github.com/docker/docker/api/types/filters" | |||
"github.com/docker/docker/api/types/image" | |||
"github.com/go-viper/mapstructure/v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should keep "github.com/mitchellh/mapstructure"
We'll create a dedicated PR to replace mitchellh/mapstructure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange, I haven't changed it manually, it looks like IDE did it. Fixed
@idsulik we're preparing a new release of Compose for Docker Desktop, if you can fix the lint issue quickly I'll merge it before doing the release 😉 |
Signed-off-by: Suleiman Dibirov <[email protected]>
@glours pushed fix. Thank you! |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https:/docker/compose) | patch | `v2.29.2` -> `v2.29.6` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.29.6`](https:/docker/compose/releases/tag/v2.29.6) [Compare Source](docker/compose@v2.29.5...v2.29.6) #### What's Changed ##### 🐛 Fixes - Don't set propagation if target engine isn't linux by [@​ndeloof](https:/ndeloof) [(12138)](docker/compose#12138) ##### ⚙️ Dependencies - build(deps): bump docker, docker/cli to v27.3.0-rc.2 by [@​thaJeztah](https:/thaJeztah) [(12136)](docker/compose#12136) **Full Changelog**: docker/compose@v2.29.5...v2.29.6 ### [`v2.29.5`](https:/docker/compose/releases/tag/v2.29.5) [Compare Source](docker/compose@v2.29.4...v2.29.5) #### What's Changed This release fix an issue with bind mounts on WSL2 when using Docker Desktop ##### 🐛 Fixes - Set propagation default by [@​ndeloof](https:/ndeloof) [(12133)](docker/compose#12133) ##### 🔧 Internal - Remove custom codeql workflow in favor of default setup by [@​temenuzhka-thede](https:/temenuzhka-thede) [(12131)](docker/compose#12131) **Full Changelog**: docker/compose@v2.29.4...v2.29.5 ### [`v2.29.4`](https:/docker/compose/releases/tag/v2.29.4) [Compare Source](docker/compose@v2.29.3...v2.29.4) #### What's Changed ##### 🐛 Fixes - Fixed possible `nil` pointer dereference by [@​disc](https:/disc) [(12127)](docker/compose#12127) - Stop dependent containers before recreating diverged service by [@​ndeloof](https:/ndeloof) [(12122)](docker/compose#12122) ##### 🔧 Internal - GHA: test against docker engine v27.3.0 by [@​thaJeztah](https:/thaJeztah) [(12126)](docker/compose#12126) - Chore(watch): Add debug log when skipping service without build context by [@​idsulik](https:/idsulik) [(12067)](docker/compose#12067) ##### ⚙️ Dependencies - Build(deps): bump docker, docker/cli to v27.3.0-rc.1, buildx v0.17.1 by [@​thaJeztah](https:/thaJeztah) [(12125)](docker/compose#12125) #### New Contributors - [@​disc](https:/disc) made their first contribution in docker/compose#12127 **Full Changelog**: docker/compose@v2.29.3...v2.29.4 ### [`v2.29.3`](https:/docker/compose/releases/tag/v2.29.3) [Compare Source](docker/compose@v2.29.2...v2.29.3) #### What's Changed ##### ✨ Improvements - Allow combination of bind mounts and 'rebuild' watches by [@​remcokranenburg](https:/remcokranenburg) [(12089)](docker/compose#12089) ##### 🐛 Fixes - Fix(wait): Wait only until first container exit by [@​idsulik](https:/idsulik) [(12064)](docker/compose#12064) - Prefer mount API over bind by [@​ndeloof](https:/ndeloof) [(12078)](docker/compose#12078) - Service hash must exclude depends_on by [@​ndeloof](https:/ndeloof) [(12072)](docker/compose#12072) - Attach: close streams when done by [@​laurazard](https:/laurazard) [(12112)](docker/compose#12112) - Restore compose v1 behavior to recreate containers when ran with `-V` by [@​ndeloof](https:/ndeloof) [(12116)](docker/compose#12116) ##### 🔧 Internal - Allow to add empty line in the logs when nav menu activated by [@​glours](https:/glours) [(12062)](docker/compose#12062) - Docs: duplicate documentation for root cmd by [@​dvdksn](https:/dvdksn) [(12076)](docker/compose#12076) - Fix typo in pull.go by [@​jonathan-dev](https:/jonathan-dev) [(12108)](docker/compose#12108) - Use logrus instead of direct output to stderr by [@​felixfontein](https:/felixfontein) [(11996)](docker/compose#11996) - Fix minor typos by [@​NathanBaulch](https:/NathanBaulch) [(12104)](docker/compose#12104) - Chore(watch): Add changed file paths/count to log by [@​idsulik](https:/idsulik) [(12118)](docker/compose#12118) ##### ⚙️ Dependencies - Build(deps): bump golang.org/x/sys from 0.22.0 to 0.25.0 by [@​dependabot](https:/dependabot) [(12101)](docker/compose#12101) - Bump engine cli v27.2.1 by [@​glours](https:/glours) [(12115)](docker/compose#12115) - Bump compose-go to version `v2.2.0` by [@​glours](https:/glours) [(12117)](docker/compose#12117) - Build(deps): bump golang.org/x/sync from `0.7.0` to `0.8.0` by [@​dependabot](https:/dependabot) [(12043)](docker/compose#12043) #### New Contributors - [@​remcokranenburg](https:/remcokranenburg) made their first contribution in [(12089)](docker/compose#12089) - [@​jonathan-dev](https:/jonathan-dev) made their first contribution in [(12108)](docker/compose#12108) - [@​NathanBaulch](https:/NathanBaulch) made their first contribution in [(12104)](docker/compose#12104) **Full Changelog**: docker/compose@v2.29.2...v2.29.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https:/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
What I did
Added debug log when skipping service without build context
Related issue
#12065
(not mandatory) A picture of a cute animal, if possible in relation to what you did