Bump engine cli v27.2.1

[glours]

What I did
Bump dependency versions:

• Engine and Cli v27.2.1
• containerd v1.7.22
• buildx v0.17.0
• buildkit v0.16.0
• Golang 1.22.7

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

[thaJeztah]

Did it automatically update this one, or did it still allow go 1.21.0 here?

I generally try to treat this one the same as other dependencies; list the minimum required version, and only update if it's impossible to use with older versions; see containerd/containerd#10596 (comment)

[thaJeztah]

mostly curious; have you tried if it allows removing this one? I know it's sometimes added automatically, but if you remove it, it doesn't add it back

[ndeloof]

LGTM. Wonder go version bump won't bring issue to release Linux system packages and need to align with engine

[thaJeztah]

Wonder go version bump won't bring issue to release Linux system packages and need to align with engine

Engine moved to go1.22 as well, so no problem there; but left the two comments above to not aggressively enforce (if possible)

(LGTM otherwise)

[thaJeztah]

Oh! You probably want to update GOLANGCI_LINT_VERSION as well for compatibility with newer go versions (CI still seemed happy, so maybe it still works); I think 1.60.2 is the current version, but you may run into linters complaining, so if it works, you could do it separately; see moby/moby#48359

[thaJeztah]

Tried locally;

pkg/watch/watcher_darwin.go:96:16: Error return value of `d.stream.Start` is not checked (errcheck)
	d.stream.Start()
	              ^
pkg/prompt/prompt.go:97:12: Error return value of `fmt.Fprint` is not checked (errcheck)
	fmt.Fprint(u.stdout, message)
	          ^
pkg/prompt/prompt.go:99:12: Error return value of `fmt.Scanln` is not checked (errcheck)
	fmt.Scanln(&answer)
	          ^
cmd/formatter/logs.go:118:15: Error return value of `fmt.Fprintf` is not checked (errcheck)
			fmt.Fprintf(w, "%s%s%s\n", p.prefix, timestamp, line)
			           ^
cmd/formatter/logs.go:120:15: Error return value of `fmt.Fprintf` is not checked (errcheck)
			fmt.Fprintf(w, "%s%s\n", p.prefix, line)
			           ^
pkg/progress/json.go:67:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
		fmt.Fprintln(p.out, string(marshal))
		            ^
pkg/progress/json.go:87:15: Error return value of `fmt.Fprintln` is not checked (errcheck)
		fmt.Fprintln(p.out, string(marshal))
		            ^
pkg/progress/plain.go:47:14: Error return value of `fmt.Fprintln` is not checked (errcheck)
	fmt.Fprintln(p.out, prefix, e.ID, e.Text, e.StatusText)
	            ^
pkg/progress/tty.go:162:12: Error return value of `fmt.Fprint` is not checked (errcheck)
	fmt.Fprint(w.out, b.Column(0).ANSI)
	          ^
pkg/progress/tty.go:165:12: Error return value of `fmt.Fprint` is not checked (errcheck)
	fmt.Fprint(w.out, aec.Hide)
	          ^
pkg/compose/attach.go:53:13: Error return value of `fmt.Fprintf` is not checked (errcheck)
	fmt.Fprintf(s.stdout(), "Attaching to %s\n", strings.Join(names, ", "))
	           ^
pkg/compose/compose.go:194:6: emptyStringTest: replace `len(dependencies) > 0` with `dependencies != ""` (gocritic)
		if len(dependencies) > 0 {
		   ^
pkg/compose/convergence.go:461:2: builtinShadow: shadowing of predeclared identifier: max (gocritic)
	max := 0
	^
pkg/compose/run.go:127:5: emptyStringTest: replace `len(opts.User) > 0` with `opts.User != ""` (gocritic)
	if len(opts.User) > 0 {
	   ^
pkg/compose/run.go:139:5: emptyStringTest: replace `len(opts.WorkingDir) > 0` with `opts.WorkingDir != ""` (gocritic)
	if len(opts.WorkingDir) > 0 {
	   ^
pkg/compose/viz.go:91:8: emptyStringTest: replace `len(portConfig.HostIP) > 0` with `portConfig.HostIP != ""` (gocritic)
				if len(portConfig.HostIP) > 0 {
				   ^
cmd/compatibility/convert.go:66:6: emptyStringTest: replace `len(arg) > 0` with `arg != ""` (gocritic)
		if len(arg) > 0 && arg[0] != '-' {
		   ^
pkg/e2e/watch_test.go:208:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
			return poll.Continue(res.Combined())
			                     ^
pkg/e2e/watch_test.go:290:25: printf: non-constant format string in call to gotest.tools/v3/poll.Continue (govet)
			return poll.Continue(r.Combined())
			                     ^

[thaJeztah]

The poll.Continue(r.Combined()) ones will be addressed by gotestyourself/gotest.tools#279, but in the meantime you can use;

poll.Continue("%v", r.Combined())

[ndeloof]

If cli/engine moved to 1.22 then I'd prefer we do the same, even code technically would be happy with 1.21

[thaJeztah]

We still keep the version in go.mod / vendor.mod at go1.21.0; https:/moby/moby/blob/34a2f953b13dd06cf09a457980f58fc30976e0ba/vendor.mod#L8

Same for BuildKit and Buildx;
https:/moby/buildkit/blob/3a7055008a5e58a2abbe0e0c21c919d9e014e062/go.mod#L3
https:/docker/buildx/blob/40f444f4b80f1c5e76f99517f01dbd6cfeec7ad8/go.mod#L3

[thaJeztah]

@glours I opened glours#44 against your PR branch (feel free to squash or change order of commits)

[thaJeztah]

LGTM (if CI is happy)