chore: drop pinned versions for dockerfile #2660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,11 +10,11 @@ COPY --from=composer /usr/bin/composer /usr/bin/composer | |||
|
|
|||
| RUN apt-get update \ | |||
There was a problem hiding this comment.
Suggested change
| RUN apt-get update \ | |
| # hadolint ignore=DL3008 | |
| RUN apt-get update \ |
suggestion: adding this line will allow unpinned package version : https:/hadolint/hadolint/wiki/DL3008
There was a problem hiding this comment.
@arnaud-deabreu Thanks for this info. Do you know, if there is a mode to use the pinned versions, with a fallback to unpinned versions?
If not, i guess it is the best, that i revert my changes. And only add your suggested commit (with a comment) to this PR.
There was a problem hiding this comment.
I think you could try with something like this:
apt-get satisfy -qq --yes --no-install-recommends \
"git (>= 1:2.30.2), git (<< 1:3)"
Chris53897
changed the title
|
I will close this, as the linked PR solves this issue better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #2624
The other fixed versions are a problem today (they worked at the time at the creation of the issue). It looks that these versions are not available/reachable anymore on mac.
Are the fixed versions necessary?
If yes, i would suggest do duplicate the actual Docker-File
Dockerfile-fallback-mac? as fallback for mac.