Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimic SemVer with apt-get satisfy for Debian deps at Dockerfile #2680

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Mimic SemVer with apt-get satisfy for Debian deps at Dockerfile #2680

merged 1 commit into from
Aug 21, 2023

Conversation

phansys
Copy link
Collaborator

@phansys phansys commented Aug 21, 2023

Closes #2660.

@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (09c2a11) 79.23% compared to head (310f9a7) 79.23%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2680   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files         161      161           
  Lines        8412     8412           
=======================================
  Hits         6665     6665           
  Misses       1747     1747

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phansys phansys requested a review from franmomu August 21, 2023 10:55
@phansys phansys marked this pull request as ready for review August 21, 2023 10:57
@phansys
Copy link
Collaborator Author

phansys commented Aug 21, 2023

@Chris53897, could you please confirm if this change resolves #2624?

franmomu
franmomu approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@franmomu franmomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My knowledge in docker is limited, so as long as it fixes the issue 👍

@Chris53897
Copy link
Contributor

Thanks @phansys
This works

@phansys phansys merged commit cb1bf94 into doctrine-extensions:main Aug 21, 2023
20 checks passed
@phansys phansys deleted the apt_satisfy branch August 21, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franmomu franmomu franmomu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @Chris53897 @franmomu