Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Champion "allow digit separator after 0b or 0x" (C# 7.2, VB 15.5) #65

Open
4 of 5 tasks
gafter opened this issue Feb 11, 2017 · 3 comments
Open
4 of 5 tasks

Champion "allow digit separator after 0b or 0x" (C# 7.2, VB 15.5) #65

gafter opened this issue Feb 11, 2017 · 3 comments
Assignees
@gafter
Labels
Implemented Needs ECMA Spec This feature has been implemented in C#, but still needs to be merged into the ECMA specification Proposal champion
Milestone
7.2

Comments

@gafter
Copy link
Member

gafter commented Feb 11, 2017 •
edited
Loading

(from dotnet/roslyn#12680)

See PR dotnet/roslyn#20449 (implemented in 15.5)
@gafter gafter self-assigned this Feb 11, 2017
@gafter gafter mentioned this issue Feb 11, 2017
Closed
@weitzhandler weitzhandler mentioned this issue Mar 6, 2017
Closed
@MadsTorgersen MadsTorgersen modified the milestone: X.X candidate May 16, 2017
@alrz alrz mentioned this issue Jun 26, 2017
Merged
@gafter gafter modified the milestones: X.X candidate, 7.2 candidate Sep 27, 2017
@gafter
Copy link
Member Author

gafter commented Sep 27, 2017

Thanks to @alrz for implementing this feature!

@jcouv jcouv changed the title Champion "allow digit separator after 0b or 0x" Champion "allow digit separator after 0b or 0x" (C# 7.2) Oct 2, 2017
@gafter gafter removed the Proposal label Oct 3, 2017
@gafter
Copy link
Member Author

gafter commented Oct 3, 2017

I added

https:/dotnet/csharplang/blob/master/proposals/csharp-7.2/leading-separator.md

which will serve as a spec.

@ufcpp ufcpp mentioned this issue Oct 13, 2017
Closed
@jcouv jcouv changed the title Champion "allow digit separator after 0b or 0x" (C# 7.2) Champion "allow digit separator after 0b or 0x" (C# 7.2, VB 15.5) Nov 7, 2017
@alrz
Copy link
Contributor

alrz commented May 7, 2018

From this blog post:

// still invalid
var c = 10_.0;  // error: next to decimal
var d = 1.1e_1; // error: next to exponent character
var e = 10_f;   // error: next to type specified

Makes sense, but probably not important enough to do yet another iteration on separators.

@333fred 333fred added the Implemented Needs ECMA Spec This feature has been implemented in C#, but still needs to be merged into the ECMA specification label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Implemented Needs ECMA Spec This feature has been implemented in C#, but still needs to be merged into the ECMA specification Proposal champion
Projects
None yet
Milestone
7.2
Development

No branches or pull requests
4 participants
@333fred @alrz @gafter @MadsTorgersen