DiagnosticIncrementalAnalyzer refactoring #39956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
WorkspaceDiagnostics
branch
6 times, most recently
from
222e6a8
to
568df59
Compare
tmat
force-pushed
the
WorkspaceDiagnostics
branch
from
568df59
to
d3e30f6
Compare
Therzok
reviewed
Nov 25, 2019
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.StateSet.cs
Outdated
Show resolved
Hide resolved
|
@mavasani Could you take a look please? |
tmat
force-pushed
the
WorkspaceDiagnostics
branch
from
5a47af7
to
7033458
Compare
mavasani
approved these changes
Nov 25, 2019
There was a problem hiding this comment.
Overall LGTM. @heejaechang might want to take a look to confirm if none of the critical perf optimizations that he might have added got removed.
...tures/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.CompilationManager.cs
Show resolved
Hide resolved
.../Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.StateManager.HostStates.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Diagnostics/DiagnosticAnalysisResult.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/DocumentState.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Nov 26, 2019
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.CompilationTracker.State.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.CompilationTracker.State.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/ProjectState.cs
Outdated
Show resolved
Hide resolved
...es/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnosticsForSpan.cs
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnostics.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnostics.cs
Outdated
Show resolved
Hide resolved
…ementalAnalyzer_GetDiagnostics.cs Co-Authored-By: Sam Harwell <[email protected]>
Co-Authored-By: Sam Harwell <[email protected]>
Co-Authored-By: Sam Harwell <[email protected]>
sharwell
approved these changes
Nov 26, 2019
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Dec 2, 2019
…ointers * dotnet/master: (197 commits) Update dependencies from https:/dotnet/arcade build 20191201.1 (dotnet#40084) Update list of C# Next features and reviewers (dotnet#39987) Update dependencies from https:/dotnet/arcade build 20191130.1 (dotnet#40075) [master] Update dependencies from dotnet/arcade (dotnet#40065) Update dependencies from https:/dotnet/arcade build 20191127.4 (dotnet#40057) Added more tests & fixed minor bug Deterministic ordering + added tests back Update dependencies from https:/dotnet/arcade build 20191126.2 (dotnet#40036) removed a test due to random order generation Always restore when running a bootstrap build (dotnet#40025) fixed integration test capitalization for extract method and extract interface Fix tests pt2 DiagnosticIncrementalAnalyzer refactoring (dotnet#39956) Persistence is always available in OOP Update src/Workspaces/Core/Portable/SolutionSize/SolutionSizeTracker.cs Fixed tests Move reporting of iterator diagnostics to avoid race condition (dotnet#39990) Update dependencies from https:/dotnet/arcade build 20191125.7 (dotnet#40020) Fix NGEN priority of csc.exe, vbc.exe, csi.exe (dotnet#40016) Accidentally deleted something ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors IncrementalDiagnosticAnalyzer to enable nullability checks, simplify and make code more readable.