Fix NGEN priority of csc.exe, vbc.exe, csi.exe #40016
Conversation
|
|
||
| <!-- Note: do not use Update attribute (see https:/microsoft/msbuild/issues/1124) --> | ||
| <DesktopCompilerArtifact NgenPriority="1" Condition="'%(Identity)' == '$(ArtifactsBinDir)csi\$(Configuration)\net472\System.Collections.Immutable.dll'" /> | ||
| <DesktopCompilerArtifact NgenPriority="1" Condition="'%(Identity)' == '$(ArtifactsBinDir)csi\$(Configuration)\net472\System.Reflection.Metadata.dll'" /> |
There was a problem hiding this comment.
@tmat can you elaborate more on why this fixed the problem? I looked at the referenced issue in MSBuild and it's still not obvious to me what is going on here. My reading of this code is still that the NgenPriority attribute should only be updated for the cases where the specified Update string was matched but this apparently is not the case.
There was a problem hiding this comment.
The bug in msbuild is that the Update attribute is ignored. So the previous code was equivalent to <DesktopCompilerArtifact NgenPriority="1"/>, which to msbuild means set NgenPriority to 1 on all existing items DesktopCompilerArtifact. Adding the condition limits this to only those items whose identity is as specified, which is what we intended to do using the Update attribute.
…ointers * dotnet/master: (197 commits) Update dependencies from https:/dotnet/arcade build 20191201.1 (dotnet#40084) Update list of C# Next features and reviewers (dotnet#39987) Update dependencies from https:/dotnet/arcade build 20191130.1 (dotnet#40075) [master] Update dependencies from dotnet/arcade (dotnet#40065) Update dependencies from https:/dotnet/arcade build 20191127.4 (dotnet#40057) Added more tests & fixed minor bug Deterministic ordering + added tests back Update dependencies from https:/dotnet/arcade build 20191126.2 (dotnet#40036) removed a test due to random order generation Always restore when running a bootstrap build (dotnet#40025) fixed integration test capitalization for extract method and extract interface Fix tests pt2 DiagnosticIncrementalAnalyzer refactoring (dotnet#39956) Persistence is always available in OOP Update src/Workspaces/Core/Portable/SolutionSize/SolutionSizeTracker.cs Fixed tests Move reporting of iterator diagnostics to avoid race condition (dotnet#39990) Update dependencies from https:/dotnet/arcade build 20191125.7 (dotnet#40020) Fix NGEN priority of csc.exe, vbc.exe, csi.exe (dotnet#40016) Accidentally deleted something ...
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1026349