Fix padding mode precondition in RSAAndroid #57695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue Detailsnull
|
jkoritzinsky
approved these changes
Aug 18, 2021
akoeplinger
approved these changes
Aug 19, 2021
stephentoub
reviewed
Aug 19, 2021
| @@ -825,7 +825,7 @@ public override bool VerifyHash(ReadOnlySpan<byte> hash, ReadOnlySpan<byte> sign | |||
| { | |||
| throw new ArgumentNullException(nameof(padding)); | |||
| } | |||
| if (padding == RSASignaturePadding.Pkcs1 && padding == RSASignaturePadding.Pss) | |||
| if (padding != RSASignaturePadding.Pkcs1 && padding != RSASignaturePadding.Pss) | |||
There was a problem hiding this comment.
I assume we have tests for this and they're just not yet running on Android? (Or maybe we're scouting them and that's how we found this?)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57683.