Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding mode precondition in RSAAndroid #57695

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix padding mode precondition in RSAAndroid #57695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libraries/Common/src/System/Security/Cryptography/RSAAndroid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ private bool TrySignHash(
Debug.Assert(padding != null);
signature = null;

if (padding == RSASignaturePadding.Pkcs1 && padding == RSASignaturePadding.Pss)
if (padding != RSASignaturePadding.Pkcs1 && padding != RSASignaturePadding.Pss)
{
throw PaddingModeNotSupported();
}
Expand Down Expand Up @@ -825,7 +825,7 @@ public override bool VerifyHash(ReadOnlySpan<byte> hash, ReadOnlySpan<byte> sign
{
throw new ArgumentNullException(nameof(padding));
}
if (padding == RSASignaturePadding.Pkcs1 && padding == RSASignaturePadding.Pss)
if (padding != RSASignaturePadding.Pkcs1 && padding != RSASignaturePadding.Pss)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we have tests for this and they're just not yet running on Android? (Or maybe we're scouting them and that's how we found this?)

{
throw PaddingModeNotSupported();
}
Expand Down