Add unit tests for SingleInstanceHelper and fix formatting from simplifying PR #11863 #12261
+136
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12261 +/- ##
===================================================
+ Coverage 75.46801% 75.46965% +0.00163%
===================================================
Files 3106 3107 +1
Lines 634445 634520 +75
Branches 46887 46897 +10
===================================================
+ Hits 478803 478870 +67
- Misses 152217 152223 +6
- Partials 3425 3427 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
* Moved to SDK RC2 to get the same build errors in VS and CLI build and be able to fix them.
Before this change the IntPreview version of VS was correctly complaining about a redundant cast(IDE0004) in ToolStrip.cs
g.DrawLines(SystemPens.ControlText, (ReadOnlySpan<Point>)
[
new(verticalBeamStart, _lastInsertionMarkRect.Y), new(verticalBeamStart, _lastInsertionMarkRect.Bottom - 1),
new(verticalBeamStart + 1, _lastInsertionMarkRect.Y), new(verticalBeamStart + 1, _lastInsertionMarkRect.Bottom - 1)
]);
But the CLI build required this cast.
After the upgrade to RC2, IDE0300 - Collection initialization can be simplified - became more robust and required code fixes that use collection expressions applied to the solution.
…net#12141) * Add XML Comments related to FileSystemProxy which includes SpecialDirectoriesProxy * Fix some types * Add some language keywords * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb Co-authored-by: Loni Tra <[email protected]> * PR feedback * Update all XML comments * Fix Typo in FileSystemProxy that caused build to fail. * Update XML Coments * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb Co-authored-by: Tanya Solyanik <[email protected]> * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb Co-authored-by: Tanya Solyanik <[email protected]> * Redo all the comments in SpecialDirectoriesProxy * Add cref per PR feedback and changed type to Namespace * PR Feedback to add see cref's --------- Co-authored-by: Loni Tra <[email protected]> Co-authored-by: Tanya Solyanik <[email protected]>
[main] Update dependencies from dotnet/runtime
Fix IDE0002 in LogTests.cs
[main] Update dependencies from dotnet/arcade
[main] Update dependencies from dotnet/runtime
…tnet#11863 (dotnet#12264) * Improve code coverage for FileLogTraceListener * Update src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/FileLogTraceListenerTests.cs Thanks I had no idea about boolData Co-authored-by: Loni Tra <[email protected]> --------- Co-authored-by: Loni Tra <[email protected]>
* Switch default feed to full wildcard * Add other wildcards back
paul1956
changed the title
...oft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/SingleInstanceHelpers.vb
Outdated
Show resolved
Hide resolved
...oft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/SingleInstanceHelpers.vb
Outdated
Show resolved
Hide resolved
...oft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/SingleInstanceHelpers.vb
Outdated
Show resolved
Hide resolved
...crosoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/SingleInstanceHelpersTests.vb
Show resolved
Hide resolved
lonitra
reviewed
Oct 8, 2024
...oft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/SingleInstanceHelpers.vb
Outdated
Show resolved
Hide resolved
...crosoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/SingleInstanceHelpersTests.vb
Outdated
Show resolved
Hide resolved
lonitra
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
lonitra
approved these changes
Oct 10, 2024
lonitra
added
the
ready-to-merge
dotnet-policy-service
bot
removed
the
ready-to-merge
paul1956
deleted the
FIx-Formatting-in-SingleInstanceHelper-From-#11863
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #12230
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow