Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for SingleInstanceHelper and fix formatting from simplifying PR #11863 #12261

Merged

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    4c61c63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4224c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Moved to SDK RC2 (dotnet#12254)

    * Moved to SDK RC2 to get the same build errors in VS and CLI build and be able to fix them.
    
    Before this change the IntPreview version of VS was correctly complaining about a redundant cast(IDE0004) in ToolStrip.cs
        g.DrawLines(SystemPens.ControlText, (ReadOnlySpan<Point>)
            [
                new(verticalBeamStart, _lastInsertionMarkRect.Y), new(verticalBeamStart, _lastInsertionMarkRect.Bottom - 1),
                new(verticalBeamStart + 1, _lastInsertionMarkRect.Y), new(verticalBeamStart + 1, _lastInsertionMarkRect.Bottom - 1)
            ]);
    
    But the CLI build required this cast.
    
    After the upgrade to RC2, IDE0300 - Collection initialization can be simplified - became more robust and required code fixes that use collection expressions applied to the solution.
    Tanya-Solyanik authored and paul1956 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2b5f268 View commit details
    Browse the repository at this point in the history
  2. Adds XML Comments to FileSystemProxy and SpecialDirectoriesProxy (dot…

    …net#12141)
    
    * Add XML Comments related to FileSystemProxy which includes SpecialDirectoriesProxy
    
    * Fix some types
    
    * Add some language keywords
    
    * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
    
    Co-authored-by: Loni Tra <[email protected]>
    
    * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
    
    Co-authored-by: Loni Tra <[email protected]>
    
    * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
    
    Co-authored-by: Loni Tra <[email protected]>
    
    * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/FileSystemProxy.vb
    
    Co-authored-by: Loni Tra <[email protected]>
    
    * PR feedback
    
    * Update all XML comments
    
    * Fix Typo in FileSystemProxy that caused build to fail.
    
    * Update XML Coments
    
    * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb
    
    Co-authored-by: Tanya Solyanik <[email protected]>
    
    * Update src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/SpecialDirectoriesProxy.vb
    
    Co-authored-by: Tanya Solyanik <[email protected]>
    
    * Redo all the comments in SpecialDirectoriesProxy
    
    * Add cref per PR feedback and changed type to Namespace
    
    * PR Feedback to add see cref's
    
    ---------
    
    Co-authored-by: Loni Tra <[email protected]>
    Co-authored-by: Tanya Solyanik <[email protected]>
    3 people committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1bcf239 View commit details
    Browse the repository at this point in the history
  3. [main] Update dependencies from dotnet/runtime (dotnet#12266)

    [main] Update dependencies from dotnet/runtime
    dotnet-maestro[bot] authored and paul1956 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b4f93e3 View commit details
    Browse the repository at this point in the history
  4. Fix IDE0002 in LogTests.cs (dotnet#12265)

    Fix IDE0002 in LogTests.cs
    paul1956 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    756e030 View commit details
    Browse the repository at this point in the history
  5. [main] Update dependencies from dotnet/arcade (dotnet#12271)

    [main] Update dependencies from dotnet/arcade
    dotnet-maestro[bot] authored and paul1956 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0267546 View commit details
    Browse the repository at this point in the history
  6. [main] Update dependencies from dotnet/runtime (dotnet#12272)

    [main] Update dependencies from dotnet/runtime
    dotnet-maestro[bot] authored and paul1956 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d049e5c View commit details
    Browse the repository at this point in the history
  7. Improve code coverage for FileLogTraceListener from simplifying PR do…

    …tnet#11863  (dotnet#12264)
    
    * Improve code coverage for FileLogTraceListener
    
    * Update src/Microsoft.VisualBasic/tests/UnitTests/Microsoft/VisualBasic/Logging/FileLogTraceListenerTests.cs
    
    Thanks I had no idea about boolData
    
    Co-authored-by: Loni Tra <[email protected]>
    
    ---------
    
    Co-authored-by: Loni Tra <[email protected]>
    paul1956 and lonitra committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d90caed View commit details
    Browse the repository at this point in the history
  8. Switch default feed to use wildcards only (dotnet#12268)

    * Switch default feed to full wildcard
    
    * Add other wildcards back
    richlander authored and paul1956 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a629958 View commit details
    Browse the repository at this point in the history
  9. Move local closer to usage

    paul1956 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    03cb5dd View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b487081 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    6887976 View commit details
    Browse the repository at this point in the history
  2. PR Feedback

    paul1956 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0119ea3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    a15c1ee View commit details
    Browse the repository at this point in the history
  2. Address PR Feedback

    paul1956 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a82f402 View commit details
    Browse the repository at this point in the history
  3. PR Feedback

    paul1956 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a278a8b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    ef78e8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    02c975c View commit details
    Browse the repository at this point in the history