Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish first version #31

Closed
SimonLab opened this issue Jan 31, 2019 · 10 comments
Closed

Publish first version #31

SimonLab opened this issue Jan 31, 2019 · 10 comments
Assignees
Labels
awaiting-review enhancement New feature or request question Further information is requested T25m technical

Comments

@SimonLab
Copy link
Member

I think this application will soon arrive at a stage where it is publishable. For that we need

@SimonLab SimonLab added enhancement New feature or request T25m technical question Further information is requested labels Jan 31, 2019
@RobStallion
Copy link
Member

I like ex_cid more personally

SimonLab added a commit that referenced this issue Jan 31, 2019
@SimonLab SimonLab mentioned this issue Jan 31, 2019
SimonLab added a commit that referenced this issue Jan 31, 2019
@nelsonic
Copy link
Member

@SimonLab / @RobStallion any reason we don't use the shorter (no underscore) version? https://hex.pm/packages/excid
image

@SimonLab
Copy link
Member Author

No other reason for me, I think I saw a couple of package using this convention (e.g ex_doc, ex_multihash) but it doesn't mean we can't use excid.
Happy to change the name, @RobStallion ?

@RobStallion
Copy link
Member

@SimonLab @nelsonic I don't mind either really. I was thinking along the same lines as you @SimonLab but there are other modules that don't have the underscore as well, excoveralls being one.

@RobStallion RobStallion removed the question Further information is requested label Jan 31, 2019
@RobStallion RobStallion self-assigned this Jan 31, 2019
RobStallion added a commit that referenced this issue Jan 31, 2019
nelsonic added a commit that referenced this issue Jan 31, 2019
@RobStallion
Copy link
Member

@SimonLab @nelsonic I have to pop out now and won't be back till about 7:30/8pm.

I will follow the instructions and update the readme with my thoughts/comments then if that is okay with you guys?

@RobStallion RobStallion added question Further information is requested and removed awaiting-review labels Jan 31, 2019
@RobStallion
Copy link
Member

Generated excid app
Docs successfully generated.
View them at "doc/index.html".
No authenticated user found. Do you want to authenticate now? [Yn]

After running mix hex.publish I got the above command. All it meant was that I had to log into hex. Wasn't a big deal but the step wasn't in the readme so I'll add it.

Was really straightforward though.

Package can be found https://hex.pm/packages/excid

@SimonLab
Copy link
Member Author

Well spotted @RobStallion , I didn't have this login issue as I've registered just before on hexpm.
Don't forget to create a tag/release on Github for this version.

@RobStallion
Copy link
Member

Ahh thanks for reminding me. That is in the readme sorry. Just slipped my mind. On it now 👍

@RobStallion
Copy link
Member

Done. Thanks @SimonLab

@nelsonic nelsonic removed their assignment Jan 31, 2019
@SimonLab SimonLab removed their assignment Feb 1, 2019
@SimonLab
Copy link
Member Author

SimonLab commented Feb 1, 2019

published at https://hex.pm/packages/excid

@SimonLab SimonLab closed this as completed Feb 1, 2019
RobStallion added a commit to dwyl/learn-elixir that referenced this issue Feb 1, 2019
nelsonic added a commit to dwyl/learn-elixir that referenced this issue Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review enhancement New feature or request question Further information is requested T25m technical
Projects
None yet
Development

No branches or pull requests

3 participants