Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First release #32

Merged
merged 3 commits into from
Jan 31, 2019
Merged

First release #32

merged 3 commits into from
Jan 31, 2019

Conversation

SimonLab
Copy link
Member

ref: #31

Udate mix.exs values to add a description, the package property and the name of the package ex_cid

@SimonLab SimonLab self-assigned this Jan 31, 2019
@codecov
Copy link

codecov bot commented Jan 31, 2019 •
edited
Loading

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #32   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          10     10           
=====================================
  Hits           10     10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aad71c...e91de2a. Read the comment docs.

@SimonLab SimonLab assigned RobStallion and nelsonic and unassigned SimonLab Jan 31, 2019
RobStallion
RobStallion approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@RobStallion RobStallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING!!! I don't know if I'm easily impressed or not but I am loving all this stuff lol. Really nice.

One comment though. I noticed on the b58 readme you added a hex badge...
image

Should we add one of those to this readme as well?

nelsonic
nelsonic approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab :shipit: (badge in the README.md would be good too...)

@nelsonic nelsonic merged commit 4f9b6a1 into master Jan 31, 2019
@nelsonic nelsonic deleted the first-release branch January 31, 2019 16:07
@SimonLab
Copy link
Member Author

badge added:
image

Just need to publish the package and the badge will be happy.
@RobStallion do you want to publish it has I've done it with base58encoding already? Let me know and we can pair quickly on this and you'll be able to add your feedback to https:/dwyl/learn-elixir#publishing

@RobStallion
Copy link
Member

@SimonLab Yeah that would be cool. Let me know whenever you are free to do this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

@RobStallion RobStallion RobStallion approved these changes

Assignees

@nelsonic nelsonic

@RobStallion RobStallion

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonLab @RobStallion @nelsonic