Extended @Column support for DB2 #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on is specified (cases no DDL change) We support optional platform columnDefinitions now. E.g. "db2;clob(64M);" - so we must not ignore @DbDefault for all other platforms
|
Yes, looks nice. Good stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add in this commit extended support for
@Columnfor DB2 platform.In DB2 we have the situation, that a
@Lobhas a default size of 1M, So we added the feature #2563 to add a platform specific definition.This caused one issue, that unnecessary migrationscripts were created for platforms, that are not listed in
@Column.So
@Column(columnDefinition = "db2;clob(16K)")->@Column(columnDefinition = "db2;clob(32K)")should not generate migrations for other platforms than DB2 (fixed here: DbMigration: Do only real type changes =We had also a problem, that it was not possible to use
@DbDefaulttogether with@Columnbecause dbColumDefault returned null in this case.The next thing is, that we want to do complex definitions like
@Column(columnDefinition = "db2;clob(16K) inline length 500 compact;")So this is valid for adding a new column, but not valid for an "alter column" statement (it must be done in two statements and things like 'compact' and 'logged' statements cannot be altered on exisiting columns.
We implemented a small parser that allow such statements both for column creation and for column alternation.
Support for extra colum options for DB2