Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Publisher/Subscriber API #218

Closed
orecham opened this issue Aug 4, 2020 · 0 comments · Fixed by #291
Closed

Improvements to Publisher/Subscriber API #218

orecham opened this issue Aug 4, 2020 · 0 comments · Fixed by #291
Assignees
@orecham
Labels
enhancement New feature example providing example for a specific feature

Comments

@orecham
Copy link
Contributor

orecham commented Aug 4, 2020

Brief feature description

The APIs for the Publisher and Subscriber should be updated to be more modern and intuitive, as well as include some requested features.

Detailed information

Improvements:

  • Modern "reactive-style" API for more expressive code
  • Remove risk of memory leak (forgetting to release unused chunks)

New features:

  • A Typed API
  • Unique IDs for Subscribers and Publishers
  • Subscribe by ID
  • Waitset Usage

These lists may not be complete.
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Created skeleton for experimental publisher API.
f354847 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Update chunk type.
5cf257f 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add notes.
d42100d 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Moved to typed chunk.
f9e449b 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add error type for recalling chunks and an al…
a2d384a 
…locate method which can be passed a lambda.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Fixed function signature in passed lambda.
5710c66 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Initial implementation of unique_ptr with sto…
2f5a499 
…red custom deleter.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add documentation to unique_ptr.
6fbede0 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add test for deleter.
ba3ed31 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Implementation of publisher API.
ad90eab 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Renamed allocate -> loan.
227cb69 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Make unique_ptr settable and comparable to nu…
6853d62 
…llptr.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add new API options and example application u…
19af029 
…sing new API.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add comments in example.
d4dc6be 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Attempt to add ability to emplace sample via …
19e2d7d 
…function call.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Implement new publisher API using SenderPort.
29ba9de 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Fix move constructor issue with sample.
d1cbb8b 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Fix bug retrieving chunk header.
cb18950 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Clean up comments.
a44bb56 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add more documentation.
946a6b0 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Clean up.
7bb3f94 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Move common publisher logic into base class.
f60ade1 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add untyped specialization of base_publisher.
30b4172 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Restructured examples & fixed move semantics …
4c18275 
…of typed publisher API.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Move all publisher classes to single file.
fc8e1e2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Add missing methods to publisher.
8858d54 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Stub basic subscriber functionality.
89d62a2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Finish publisher implementation.
f2da5b2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 Polling receiver implementation.
8b8e23d 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to MatthiasKillat/iceoryx that referenced this issue Sep 11, 2020
@orecham
iox-eclipse-iceoryx#218 More methods in BaseSubscriber.
5771103 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@elBoberido elBoberido mentioned this issue Sep 21, 2020
Closed
3 tasks
marthtz added a commit to marthtz/iceoryx that referenced this issue Sep 21, 2020
@marthtz
iox-eclipse-iceoryx#218: Add unique ptr files from PR eclipse-iceoryx…
4af9704 
…#291

Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
iox-eclipse-iceoryx#218 Fix bug in Sample move ctor.
feaee03 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
marthtz added a commit to marthtz/iceoryx that referenced this issue Sep 22, 2020
@marthtz
iox-eclipse-iceoryx#218: Add unique ptr files from PR eclipse-iceoryx…
af01334 
…#291

Signed-off-by: Hintz Martin (CC-AD/ESW1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
iox-eclipse-iceoryx#218 Add pedantic tests for typed and untyped subs…
402633f 
…criber.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
iox-eclipse-iceoryx#218 Remove type traits - will merge in from master.
012c850 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
Merge remote-tracking branch 'origin/master' into iox-eclipse-iceoryx…
30739c0 
…#218-improve-pub-sub-api
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
iox-eclipse-iceoryx#218 Use type traits from master.
e0467f7 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
iox-eclipse-iceoryx#218 Remove "experimental" from test names.
b014374 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
iox-eclipse-iceoryx#218 Fix test that only fails on mac...
2e36080 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 22, 2020
@orecham
iox-eclipse-iceoryx#218 Fix test that only fails on mac...
4f0d571 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
dkroenke added a commit to dkroenke/iceoryx that referenced this issue Sep 23, 2020
@dkroenke
iox-eclipse-iceoryx#218 add nicemock to publisher mock
04164bc 
Signed-off-by: Kroenke Dietrich (CC-AD/ESW1) <[email protected]>
dkroenke added a commit to dkroenke/iceoryx that referenced this issue Sep 23, 2020
@dkroenke
iox-eclipse-iceoryx#218 at least one call for apple
f199c6c 
Signed-off-by: Kroenke Dietrich (CC-AD/ESW1) <[email protected]>
dkroenke added a commit to dkroenke/iceoryx that referenced this issue Sep 23, 2020
@dkroenke
iox-eclipse-iceoryx#218 at least one call for apple
0bb7cd2 
Signed-off-by: Kroenke Dietrich (CC-AD/ESW1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 24, 2020
@orecham
iox-eclipse-iceoryx#218 Fix mac build.
f359f7e 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 24, 2020
@orecham
iox-eclipse-iceoryx#218 Rename experimental api to modern api.
d40cddd 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 29, 2020
@orecham
iox-eclipse-iceoryx#218 Sample test.
61dc7ef 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 29, 2020
@orecham
Merge branch 'iox-eclipse-iceoryx#298-add-unique-ptr-implementation' …
9359acb 
…into iox-eclipse-iceoryx#218-improve-pub-sub-api
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 29, 2020
@orecham
iox-eclipse-iceoryx#218 Adapt to new unique_ptr API.
80b471e 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 29, 2020
@orecham
iox-eclipse-iceoryx#218 Clang format.
d7df2b2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 29, 2020
@orecham
iox-eclipse-iceoryx#218 Remove "experimental" from include guards.
3a04dd9 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
orecham added a commit to elBoberido/iceoryx that referenced this issue Sep 30, 2020
@orecham
Merge remote-tracking branch 'origin/master' into iox-eclipse-iceoryx…
1064bc9 
…#218-improve-pub-sub-api
@mossmaurice mossmaurice added enhancement New feature example providing example for a specific feature labels Nov 2, 2020
orecham added a commit that referenced this issue Nov 2, 2020
@orecham
Merge pull request #291 from elBoberido/iox-#218-improve-pub-sub-api
39afa64 
Iox #218 improve pub sub api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orecham orecham

Labels
enhancement New feature example providing example for a specific feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iox #218 improve pub sub api elBoberido/iceoryx
2 participants
@orecham @mossmaurice