Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iox #218 improve pub sub api #291

Merged
merged 86 commits into from
Nov 2, 2020
Merged

Iox #218 improve pub sub api #291

merged 86 commits into from
Nov 2, 2020

Conversation

elBoberido
Copy link
Member

code cotributed by @ithier

closes #218

@orecham
iox-eclipse-iceoryx#218 Created skeleton for experimental publisher API.
f354847 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Update chunk type.
5cf257f 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add notes.
d42100d 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Moved to typed chunk.
f9e449b 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add error type for recalling chunks and an al…
a2d384a 
…locate method which can be passed a lambda.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Fixed function signature in passed lambda.
5710c66 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Initial implementation of unique_ptr with sto…
2f5a499 
…red custom deleter.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add documentation to unique_ptr.
6fbede0 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add test for deleter.
ba3ed31 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Implementation of publisher API.
ad90eab 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Renamed allocate -> loan.
227cb69 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Make unique_ptr settable and comparable to nu…
6853d62 
…llptr.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add new API options and example application u…
19af029 
…sing new API.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add comments in example.
d4dc6be 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Attempt to add ability to emplace sample via …
19e2d7d 
…function call.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Implement new publisher API using SenderPort.
29ba9de 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Fix move constructor issue with sample.
d1cbb8b 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Fix bug retrieving chunk header.
cb18950 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Clean up comments.
a44bb56 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add more documentation.
946a6b0 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Clean up.
7bb3f94 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Move common publisher logic into base class.
f60ade1 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add untyped specialization of base_publisher.
30b4172 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Restructured examples & fixed move semantics …
4c18275 
…of typed publisher API.

Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Move all publisher classes to single file.
fc8e1e2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Add missing methods to publisher.
8858d54 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Stub basic subscriber functionality.
89d62a2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Finish publisher implementation.
f2da5b2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Polling receiver implementation.
8b8e23d 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 More methods in BaseSubscriber.
5771103 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham orecham force-pushed the iox-#218-improve-pub-sub-api branch 2 times, most recently from 2e36080 to 4f0d571 Compare September 22, 2020 13:53
@orecham
iox-eclipse-iceoryx#218 Fix mac build.
f359f7e 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
@orecham
iox-eclipse-iceoryx#218 Clang format.
d7df2b2 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <[email protected]>
mossmaurice
mossmaurice reviewed Sep 30, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
mossmaurice
mossmaurice approved these changes Oct 29, 2020
View reviewed changes
iceoryx_examples/icedelivery/iox_publisher_typed_modern.cpp Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/modern_api/base_subscriber.inl Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/internal/popo/modern_api/sample.inl Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/popo/modern_api/base_publisher.hpp Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/popo/modern_api/base_subscriber.hpp Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/popo/modern_api/typed_publisher.hpp Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/popo/modern_api/typed_subscriber.hpp Show resolved Hide resolved
iceoryx_posh/include/iceoryx_posh/popo/modern_api/untyped_subscriber.hpp Show resolved Hide resolved
iceoryx_posh/test/moduletests/test_popo_base_subscriber.cpp Show resolved Hide resolved
iceoryx_posh/test/moduletests/test_popo_sample.cpp Show resolved Hide resolved
@budrus budrus self-requested a review November 2, 2020 13:11
budrus
budrus approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@budrus budrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far, we continue with the next PR

@orecham orecham dismissed stale reviews from dkroenke and elfenpiff November 2, 2020 14:17

changes have been addressed

@orecham orecham merged commit 39afa64 into eclipse-iceoryx:master Nov 2, 2020
@orecham orecham deleted the iox-#218-improve-pub-sub-api branch November 2, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marthtz marthtz marthtz left review comments

@MatthiasKillat MatthiasKillat MatthiasKillat left review comments

@orecham orecham orecham approved these changes

@mossmaurice mossmaurice mossmaurice approved these changes

@budrus budrus budrus approved these changes

@dkroenke dkroenke Awaiting requested review from dkroenke

@elfenpiff elfenpiff Awaiting requested review from elfenpiff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements to Publisher/Subscriber API
8 participants
@elBoberido @orecham @mossmaurice @marthtz @dkroenke @budrus @elfenpiff @MatthiasKillat