Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#220 require C++14 for iceoryx #390

Merged
merged 5 commits into from
Nov 25, 2020

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 23, 2020

Signed-off-by: Mathias Kraus [email protected]

Pre-Review Checklist for the PR Author

  1. Branch follows the naming format (iox-#123-this-is-a-branch)
  2. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  3. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  4. Relevant issues are linked
  5. Add sensible notes for the reviewer
  6. All checks have passed
  7. Assign PR to reviewer

Notes for Reviewer

Switch to C++14. This makes lambdas more convenient to use with auto and enables if and switch statements and loops in constexpr-declared functions.
Additionally we can use the standard [[deprecated]] attribute instead of [[gnu::deprecated]]

https://en.wikipedia.org/wiki/C++14

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

  1. All checkboxes in the PR checklist are checked or crossed out
  2. Merge

References

elfenpiff
elfenpiff previously approved these changes Nov 23, 2020
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use C++11, however we try to introduce C++14 as fast as possible

Could you update the CONTRIBUTING.md?

You could also remove enable_if_t from the iceoryx_utils/include/iceoryx_utils/cxx/type_trait.hpp

@elfenpiff elfenpiff self-requested a review November 25, 2020 09:51
@elBoberido elBoberido merged commit 1791f1a into eclipse-iceoryx:master Nov 25, 2020
@elBoberido elBoberido deleted the iox-#220-switch-to-C++14 branch November 25, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++14
5 participants