iox-#220 require C++14 for iceoryx

CONTRIBUTING.md

@@ -76,7 +76,7 @@ codebase follows these rules, things are work in progress.
  without heap)
 2) **No exception are allowed**, all function and methods need to have `noexcept` in their signature
 3) **No undefined behavior**, zero-cost abstract is not feasible in high safety environments
-4) **Use C++11**, however we try to introduce C++14 as fast as possible
+4) **Use C++14**
 5) **[Rule of Five](https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming))**, if there is a non-default
  destructor needed, the rule of five has to be applied
 6) **[STL](https://en.wikipedia.org/wiki/Standard_Template_Library)**, we aim to be compatible towards the STL, but

iceoryx_binding_c/CMakeLists.txt

@@ -60,7 +60,11 @@ add_library(${PROJECT_NAME}
 )
 add_library(${PROJECT_NAMESPACE}::${PROJECT_NAME} ALIAS ${PROJECT_NAME})
 
-set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 11)
+set_target_properties(${PROJECT_NAME} PROPERTIES
+ CXX_STANDARD_REQUIRED ON
+ CXX_STANDARD ${ICEORYX_CXX_STANDARD}
+ POSITION_INDEPENDENT_CODE ON
+)
 
 target_include_directories(${PROJECT_NAME}
  PUBLIC

iceoryx_binding_c/test/CMakeLists.txt

@@ -54,7 +54,7 @@ endif()
 
 # unittests
 add_executable(${PROJECT_PREFIX}_integrationtests ${MODULETESTS_SRC})
-set_property(TARGET ${PROJECT_PREFIX}_integrationtests PROPERTY CXX_STANDARD 11)
+set_property(TARGET ${PROJECT_PREFIX}_integrationtests PROPERTY CXX_STANDARD ${ICEORYX_CXX_STANDARD})
 target_include_directories(${PROJECT_PREFIX}_integrationtests PRIVATE .)
 target_compile_options(${PROJECT_PREFIX}_integrationtests PUBLIC -fPIC PRIVATE ${TEST_CXX_FLAGS})
 target_link_libraries(${PROJECT_PREFIX}_integrationtests ${TEST_LINK_LIBS})

iceoryx_dds/CMakeLists.txt

@@ -55,7 +55,11 @@ add_library(iceoryx_dds
 )
 add_library(${PROJECT_NAMESPACE}::iceoryx_dds ALIAS iceoryx_dds)
 
-target_compile_options(iceoryx_dds PUBLIC -std=c++11)
+set_target_properties(iceoryx_utils PROPERTIES
+ CXX_STANDARD_REQUIRED ON
+ CXX_STANDARD ${ICEORYX_CXX_STANDARD}
+ POSITION_INDEPENDENT_CODE ON
+)
 
 target_include_directories(iceoryx_dds
  PUBLIC

iceoryx_dds/test/CMakeLists.txt

@@ -51,7 +51,7 @@ endif()
 
 # unittests
 add_executable(${PROJECT_PREFIX}_moduletests ${MODULETESTS_SRC})
-set_property(TARGET ${PROJECT_PREFIX}_moduletests PROPERTY CXX_STANDARD 11)
+set_property(TARGET ${PROJECT_PREFIX}_moduletests PROPERTY CXX_STANDARD ${ICEORYX_CXX_STANDARD})
 target_include_directories(${PROJECT_PREFIX}_moduletests PRIVATE .)
 target_compile_options(${PROJECT_PREFIX}_moduletests PUBLIC -fPIC PRIVATE ${TEST_CXX_FLAGS})
 target_link_libraries(${PROJECT_PREFIX}_moduletests ${TEST_LINK_LIBS})

iceoryx_posh/include/iceoryx_posh/internal/roudi/port_manager.hpp

@@ -151,11 +151,11 @@ class PortManager
  void addEntryToServiceRegistry(const capro::IdString& service, const capro::IdString& instance) noexcept;
  void removeEntryFromServiceRegistry(const capro::IdString& service, const capro::IdString& instance) noexcept;
 
- template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>* = nullptr>
+ template <typename T, std::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>* = nullptr>
  cxx::optional<ProcessName_t> doesViolateCommunicationPolicy(const capro::ServiceDescription& service) const
  noexcept;
 
- template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>* = nullptr>
+ template <typename T, std::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>* = nullptr>
  cxx::optional<ProcessName_t> doesViolateCommunicationPolicy(const capro::ServiceDescription& service
  [[gnu::unused]]) const noexcept;
 

iceoryx_posh/include/iceoryx_posh/internal/roudi/port_manager.inl

@@ -18,7 +18,7 @@ namespace iox
 {
 namespace roudi
 {
-template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>*>
+template <typename T, std::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>*>
 inline cxx::optional<ProcessName_t>
 PortManager::doesViolateCommunicationPolicy(const capro::ServiceDescription& service) const noexcept
 {
@@ -34,7 +34,7 @@ PortManager::doesViolateCommunicationPolicy(const capro::ServiceDescription& ser
  return cxx::nullopt;
 }
 
-template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>*>
+template <typename T, std::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>*>
 inline cxx::optional<ProcessName_t> PortManager::doesViolateCommunicationPolicy(const capro::ServiceDescription& service
  [[gnu::unused]]) const noexcept
 {

iceoryx_posh/include/iceoryx_posh/roudi/port_pool.hpp

@@ -95,13 +95,13 @@ class PortPool
  const ProcessName_t& applicationName,
  const mepoo::MemoryInfo& memoryInfo = mepoo::MemoryInfo()) noexcept;
 
- template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>* = nullptr>
+ template <typename T, std::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>* = nullptr>
  iox::popo::SubscriberPortData* constructSubscriber(const capro::ServiceDescription& serviceDescription,
  const uint64_t& historyRequest,
  const ProcessName_t& applicationName,
  const mepoo::MemoryInfo& memoryInfo) noexcept;
 
- template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>* = nullptr>
+ template <typename T, std::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>* = nullptr>
  iox::popo::SubscriberPortData* constructSubscriber(const capro::ServiceDescription& serviceDescription,
  const uint64_t& historyRequest,
  const ProcessName_t& applicationName,

iceoryx_posh/include/iceoryx_posh/roudi/port_pool.inl

@@ -18,7 +18,7 @@ namespace iox
 {
 namespace roudi
 {
-template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>*>
+template <typename T, std::enable_if_t<std::is_same<T, iox::build::ManyToManyPolicy>::value>*>
 inline iox::popo::SubscriberPortData* PortPool::constructSubscriber(const capro::ServiceDescription& serviceDescription,
  const uint64_t& historyRequest,
  const ProcessName_t& applicationName,
@@ -31,7 +31,7 @@ inline iox::popo::SubscriberPortData* PortPool::constructSubscriber(const capro:
  memoryInfo);
 }
 
-template <typename T, cxx::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>*>
+template <typename T, std::enable_if_t<std::is_same<T, iox::build::OneToManyPolicy>::value>*>
 inline iox::popo::SubscriberPortData* PortPool::constructSubscriber(const capro::ServiceDescription& serviceDescription,
  const uint64_t& historyRequest,
  const ProcessName_t& applicationName,

iceoryx_posh/include/iceoryx_posh/roudi/roudi_app.hpp

@@ -40,7 +40,7 @@ class RouDiApp
  static RouDiConfig_t generateConfigFromMePooConfig(const mepoo::MePooConfig* mePooConfig) noexcept;
 
  /// @deprecated Please port to RouDiApp(const CmdLineParser&, const RouDiConfig_T&)
- [[gnu::deprecated]] RouDiApp(int argc, char* argv[], const mepoo::MePooConfig* mePooConfig = nullptr) noexcept;
+ [[deprecated]] RouDiApp(int argc, char* argv[], const mepoo::MePooConfig* mePooConfig = nullptr) noexcept;
 
  /// @deprecated Will be deprecated soon, please port to RouDiApp(const CmdLineParser&, const RouDiConfig_T&)
  RouDiApp(int argc, char* argv[], const RouDiConfig_t& config) noexcept;

iceoryx_utils/cmake/IceoryxPlatformDetection.cmake

@@ -22,11 +22,11 @@ if(UNIX AND NOT APPLE)
 endif(UNIX AND NOT APPLE)
 
 if(LINUX)
- set(ICEORYX_CXX_STANDARD 11)
+ set(ICEORYX_CXX_STANDARD 14)
 elseif(QNX)
- set(ICEORYX_CXX_STANDARD 11)
+ set(ICEORYX_CXX_STANDARD 14)
 elseif(WIN32)
- set(ICEORYX_CXX_STANDARD 11)
+ set(ICEORYX_CXX_STANDARD 14)
 elseif(APPLE)
  set(ICEORYX_CXX_STANDARD 17)
 endif(LINUX)

iceoryx_utils/include/iceoryx_utils/cxx/expected.hpp

@@ -255,7 +255,7 @@ class expected<ErrorType>
  /// std::cout << "error occured : " << result.get_error() << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_error(const cxx::function_ref<void(expected&)>& callable) const noexcept;
+ [[deprecated]] const expected& on_error(const cxx::function_ref<void(expected&)>& callable) const noexcept;
 
  /// @brief if the expected does contain an error the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -266,7 +266,7 @@ class expected<ErrorType>
  /// std::cout << "error occured : " << result.get_error() << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_error(const cxx::function_ref<void(expected&)>& callable) noexcept;
+ [[deprecated]] expected& on_error(const cxx::function_ref<void(expected&)>& callable) noexcept;
 
  /// @brief if the expected does contain an error the given callable is called and
  /// a reference to the ErrorType is given as an argument to the callable
@@ -277,7 +277,7 @@ class expected<ErrorType>
  /// std::cout << "error occured : " << error << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) const noexcept;
+ [[deprecated]] const expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) const noexcept;
  const expected& or_else(const cxx::function_ref<void(ErrorType&)>& callable) const noexcept;
 
  /// @brief if the expected does contain an error the given callable is called and
@@ -289,7 +289,7 @@ class expected<ErrorType>
  /// std::cout << "error occured : " << error << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) noexcept;
+ [[deprecated]] expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) noexcept;
  expected& or_else(const cxx::function_ref<void(ErrorType&)>& callable) noexcept;
 
  /// @brief if the expected does contain an error the given callable is called
@@ -300,7 +300,7 @@ class expected<ErrorType>
  /// std::cout << "error occured " << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_error(const cxx::function_ref<void()>& callable) const noexcept;
+ [[deprecated]] const expected& on_error(const cxx::function_ref<void()>& callable) const noexcept;
 
  /// @brief if the expected does contain an error the given callable is called
  /// @param[in] callable callable which will be called if the expected contains an error
@@ -310,7 +310,7 @@ class expected<ErrorType>
  /// std::cout << "error occured " << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_error(const cxx::function_ref<void()>& callable) noexcept;
+ [[deprecated]] expected& on_error(const cxx::function_ref<void()>& callable) noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -321,7 +321,7 @@ class expected<ErrorType>
  /// std::cout << "we are successful" << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_success(const cxx::function_ref<void(expected&)>& callable) const noexcept;
+ [[deprecated]] const expected& on_success(const cxx::function_ref<void(expected&)>& callable) const noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -332,7 +332,7 @@ class expected<ErrorType>
  /// std::cout << "we are successful" << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_success(const cxx::function_ref<void(expected&)>& callable) noexcept;
+ [[deprecated]] expected& on_success(const cxx::function_ref<void(expected&)>& callable) noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -343,7 +343,7 @@ class expected<ErrorType>
  /// std::cout << "we are successful!" << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_success(const cxx::function_ref<void()>& callable) const noexcept;
+ [[deprecated]] const expected& on_success(const cxx::function_ref<void()>& callable) const noexcept;
  const expected& and_then(const cxx::function_ref<void()>& callable) const noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
@@ -355,7 +355,7 @@ class expected<ErrorType>
  /// std::cout << "we are successful!" << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_success(const cxx::function_ref<void()>& callable) noexcept;
+ [[deprecated]] expected& on_success(const cxx::function_ref<void()>& callable) noexcept;
  expected& and_then(const cxx::function_ref<void()>& callable) noexcept;
 
  private:
@@ -566,7 +566,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "error occured : " << result.get_error() << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_error(const cxx::function_ref<void(expected&)>& callable) const noexcept;
+ [[deprecated]] const expected& on_error(const cxx::function_ref<void(expected&)>& callable) const noexcept;
 
  /// @brief if the expected does contain an error the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -577,7 +577,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "error occured : " << result.get_error() << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_error(const cxx::function_ref<void(expected&)>& callable) noexcept;
+ [[deprecated]] expected& on_error(const cxx::function_ref<void(expected&)>& callable) noexcept;
 
  /// @brief if the expected does contain an error the given callable is called and
  /// a reference to the ErrorType is given as an argument to the callable
@@ -588,7 +588,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "error occured : " << error << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) const noexcept;
+ [[deprecated]] const expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) const noexcept;
  const expected& or_else(const cxx::function_ref<void(ErrorType&)>& callable) const noexcept;
 
  /// @brief if the expected does contain an error the given callable is called and
@@ -600,7 +600,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "error occured : " << error << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) noexcept;
+ [[deprecated]] expected& on_error(const cxx::function_ref<void(ErrorType&)>& callable) noexcept;
  expected& or_else(const cxx::function_ref<void(ErrorType&)>& callable) noexcept;
 
  /// @brief if the expected does contain an error the given callable is called
@@ -611,7 +611,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "error occured " << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_error(const cxx::function_ref<void()>& callable) const noexcept;
+ [[deprecated]] const expected& on_error(const cxx::function_ref<void()>& callable) const noexcept;
 
  /// @brief if the expected does contain an error the given callable is called
  /// @param[in] callable callable which will be called if the expected contains an error
@@ -621,7 +621,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "error occured " << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_error(const cxx::function_ref<void()>& callable) noexcept;
+ [[deprecated]] expected& on_error(const cxx::function_ref<void()>& callable) noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -632,7 +632,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "we have a result : " << result.get_value() << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_success(const cxx::function_ref<void(expected&)>& callable) const noexcept;
+ [[deprecated]] const expected& on_success(const cxx::function_ref<void(expected&)>& callable) const noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -643,7 +643,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "we have a result : " << result.get_value() << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_success(const cxx::function_ref<void(expected&)>& callable) noexcept;
+ [[deprecated]] expected& on_success(const cxx::function_ref<void(expected&)>& callable) noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
  /// a reference to the result is given as an argument to the callable
@@ -654,7 +654,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "we have a result : " << result << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_success(const cxx::function_ref<void(ValueType&)>& callable) const noexcept;
+ [[deprecated]] const expected& on_success(const cxx::function_ref<void(ValueType&)>& callable) const noexcept;
  const expected& and_then(const cxx::function_ref<void(ValueType&)>& callable) const noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
@@ -666,7 +666,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "we have a result : " << result << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_success(const cxx::function_ref<void(ValueType&)>& callable) noexcept;
+ [[deprecated]] expected& on_success(const cxx::function_ref<void(ValueType&)>& callable) noexcept;
  expected& and_then(const cxx::function_ref<void(ValueType&)>& callable) noexcept;
 
  ///
@@ -706,7 +706,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "we are successful!" << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] const expected& on_success(const cxx::function_ref<void()>& callable) const noexcept;
+ [[deprecated]] const expected& on_success(const cxx::function_ref<void()>& callable) const noexcept;
 
  /// @brief if the expected does contain a success value the given callable is called and
  /// a reference to the expected is given as an argument to the callable
@@ -717,7 +717,7 @@ class expected<ValueType, ErrorType>
  /// std::cout << "we are successful!" << std::endl;
  /// })
  /// @endcode
- [[gnu::deprecated]] expected& on_success(const cxx::function_ref<void()>& callable) noexcept;
+ [[deprecated]] expected& on_success(const cxx::function_ref<void()>& callable) noexcept;
 
  ///
  /// @brief if the expected contains a success value and its type is an empty optional, calls the provided callable